Bug 861331

Reproduced on qemu-kvm-0.12.1.2-2.323.el6, migration failed on the destination side with usb-redir devices.
Steps:
1. Boot guest with usb redirection
-device usb-ehci,id=ehci,addr=0x7 -chardev spicevmc,name=usbredir,id=usbredirchardev1 -device usb-redir,chardev=usbredirchardev1,id=usbredirdev1,bus=ehci.0,debug=3

2. Connect spice client with spicy tools (provided by spice-gtk-tools)

3. Select "Auto redirect newly plugged in USB devices" in "Option" menu. And then plug a USB disk to spice client host.
  
4. Migrate guest.
(qemu) __com.redhat_spice_migrate_info $dst_host_ip $dst_host_port 
(qemu) migrate -d tcp:$dst_host_ip:5800

Result:
Migration failed on dst host:

(qemu) red_dispatcher_loadvm_commands: 
qemu-kvm: usb-redir error: get_parser called with closed chardev, failing migration
qemu: warning: error while loading state for instance 0x0 of device '0000:00:07.0/1/usb-redir'

Verified on qemu-kvm-0.12.1.2-2.327.el6:

(1) seamless-migration (seamless-migration=on):
Test with the same steps as above, migration finished successfully and the usb disk is still over there, can read/write the USB disk.

(2) Non seamless migration (seamless-migraton=off):
Migration could finish successfully. But usb disk is gone inside guest after migration.  
Some qemu log:

(qemu) main_channel_link: add main channel client
red_dispatcher_loadvm_commands: 
main_channel_send_item: Init msg for client 0x7fbba91286d0 was not sent yet (client is probably during semi-seamless migration). Ignoring msg type 103
main_channel_send_item: Init msg for client 0x7fbba91286d0 was not sent yet (client is probably during semi-seamless migration). Ignoring msg type 116
qemu-kvm: usb-redir warning: usb-redir connection broken during migration

Hi, Hans
I have two questions:
(1) Is it the expected result that the usb-redir connection broken during migration with the non seamless migration? Why? 
(2) What does it mean in your bug description: "This allows migration of vms with a non-seamless capable client connected and also allows restoring vms saved to disk"?  What does the "allows restoring vms saved to disk"? 


Thanks,
Qunfang

(In reply to comment #3)
> Hi, Hans
> I have two questions:
> (1) Is it the expected result that the usb-redir connection broken during
> migration with the non seamless migration?

Yes

> Why? 

Successfull migration with USB-devices enabled requires seamless migration. The reason we
want to also allow it without seamless is because of 2:

> (2) What does it mean in your bug description: "This allows migration of vms
> with a non-seamless capable client connected and also allows restoring vms
> saved to disk"?  What does the "allows restoring vms saved to disk"? 

What I mean is that it allows migrate to / from disk, which can be used to save
the state of a vm to disk to later restore it. Without this patch the restoring
would be impossible, as it would detect a non seamless migration and abort the
migrate from disk.

Regards,

Hans

(In reply to comment #4)
> (In reply to comment #3)
> > Hi, Hans
> > I have two questions:
> > (1) Is it the expected result that the usb-redir connection broken during
> > migration with the non seamless migration?
> 
> Yes
> 
> > Why? 
> 
> Successfull migration with USB-devices enabled requires seamless migration.
> The reason we
> want to also allow it without seamless is because of 2:
> 
> > (2) What does it mean in your bug description: "This allows migration of vms
> > with a non-seamless capable client connected and also allows restoring vms
> > saved to disk"?  What does the "allows restoring vms saved to disk"? 
> 
> What I mean is that it allows migrate to / from disk, which can be used to
> save
> the state of a vm to disk to later restore it. Without this patch the
> restoring
> would be impossible, as it would detect a non seamless migration and abort
> the
> migrate from disk.
> 
> Regards,
> 
> Hans

OK, so this bug can be verified pass, right? BTW, when do we plan to allow the successfully migration with usb-redirection devices with non seamless migration? Do we have a bz to track it? 

Thanks,
Qunfang

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Hi, Hans
> > > I have two questions:
> > > (1) Is it the expected result that the usb-redir connection broken during
> > > migration with the non seamless migration?
> > 
> > Yes
> > 
> > > Why? 
> > 
> > Successfull migration with USB-devices enabled requires seamless migration.
> > The reason we
> > want to also allow it without seamless is because of 2:
> > 
> > > (2) What does it mean in your bug description: "This allows migration of vms
> > > with a non-seamless capable client connected and also allows restoring vms
> > > saved to disk"?  What does the "allows restoring vms saved to disk"? 
> > 
> > What I mean is that it allows migrate to / from disk, which can be used to
> > save
> > the state of a vm to disk to later restore it. Without this patch the
> > restoring
> > would be impossible, as it would detect a non seamless migration and abort
> > the
> > migrate from disk.
> > 
> > Regards,
> > 
> > Hans
> 
> OK, so this bug can be verified pass, right?

Right.

> BTW, when do we plan to allow
> the successfully migration with usb-redirection devices with non seamless
> migration?

Never, migration with usb-redirection devices connected, and keeping them
connected after migration is only supported with seamless migraton.

OK, get it and thank you.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-0527.html