Bug 862235

Summary: kickstart snippets added/changed on disk do not always take effect
Product: [Retired] Beaker Reporter: Raymond Mancy <rmancy>
Component: schedulerAssignee: Dan Callaghan <dcallagh>
Status: CLOSED CURRENTRELEASE QA Contact: Amit Saha <asaha>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 0.9CC: asaha, dcallagh, ebaak, junichi.nomura, mishin, rglasz, rmancy
Target Milestone: 0.10.0   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: Kickstart
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-11-22 06:42:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Raymond Mancy 2012-10-02 11:51:16 UTC
Description of problem:

Adding a custom sinppet will not take affect 

Version-Release number of selected component (if applicable):


How reproducible:
always (for a provisioned job)

Steps to Reproduce:
1. Add snippet that overrides installed snippet
2. add job to scheduler that uses snippet
3.
  
Actual results:

new snippet is not used

Expected results:

I guess we're expecting it to be. 

Additional info:

We could add cache=None to the the SandboxedEnvironment constructor.

I think jinja should be able to do this unless there is a good reason not to, I think the current behvaiour is unexpected.

Comment 1 Raymond Mancy 2012-10-02 20:38:38 UTC
by cache=None, I of course mean 'cache_size=0'.To be clear, the snippet will take affect if the process (beakerd in this case) is restarted.

Comment 2 Raymond Mancy 2012-10-09 05:00:16 UTC
I've also filed an upstream bug for this.

Comment 3 Raymond Mancy 2012-10-09 05:04:35 UTC
https://github.com/mitsuhiko/jinja2/issues/153

Comment 4 Dan Callaghan 2012-11-01 01:37:09 UTC
On Gerrit: http://gerrit.beaker-project.org/1458

Comment 5 Amit Saha 2012-11-13 01:03:25 UTC
Verified by creating /etc/beaker/snippets/network with the following contents:

#dummy network configuration

This line is included in the generated kickstart file, instead of the usually found:

# no specific network configuration

Comment 6 Raymond Mancy 2012-11-22 06:42:41 UTC
This has now been released