Bug 862260
| Summary: | [RFE] engine-iso-uploader: update command-line usage (URL based location, etc.) | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-iso-uploader | Reporter: | Alon Bar-Lev <alonbl> |
| Component: | Core | Assignee: | Sandro Bonazzola <sbonazzo> |
| Status: | CLOSED DEFERRED | QA Contact: | Pavel Stehlik <pstehlik> |
| Severity: | low | Docs Contact: | |
| Priority: | medium | ||
| Version: | --- | CC: | bsettle, bugs, dfediuck, didi, jbelka, ldelouw, lveyde, mgoldboi, rbalakri, Rhev-m-bugs, rmartins, sbonazzo, stirabos, ylavi |
| Target Milestone: | --- | Keywords: | FutureFeature, Improvement |
| Target Release: | --- | Flags: | sbonazzo:
ovirt-future?
rule-engine: planning_ack? sbonazzo: devel_ack? rule-engine: testing_ack? |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Enhancement | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-06-07 21:28:54 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Integration | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
This was discussed some time ago with Keith Robertson and Itamar Heim. Maybe we want also a list-domains command in order to preserve the functionality provided by current list command. Having also the download command could be useful. Maybe ovirt-engin-iso-uploader will be reductive for the tool, ovirt-engine-iso-ctl or ovirt-engine-iso-manager could be more appropriate. We should merge the image and iso uploaders into single tool If there is only one ISO domain, does engine-iso-uploader have to ask for its name? This is sooooo annoying. Doesn't seems weekathon material to me. Yaniv, can we close this one since ovirt-iso-uploader is deprecated in favor of ovirt-imageio? I would wait for the replacement feature to be in. (In reply to Yaniv Lavi from comment #8) > I would wait for the replacement feature to be in. We are not going to change the command line nevertheless. Closing for the time being. |
CURRENT STATUS engine-iso-uploader command-line interface is hard to use, there is no explicit method to select transport (ssh, nfs), there is implicit behaviour, such as if one specifies ssh user then ssh is used. It is also hard to understand how it can be used with or without engine, and it is very hard to extend in coherent approach. SUGGESTION Alter the command-line interface to be similar to other network tools, by making it URL based. Usage: engine-iso-uploader [options] command source [source...] destination -c|--config file - read configuration from file. -o|--option option=value - set configuration option --engine - engine to use (rest api) URL notation. command list - list iso images upload - upload iso images download - download iso images source - URL of source. destination - URL of destination. URL notation: protocol://user:password@host:port/path?arguments Supported local destinations: file://path /path Supported remote destinations: nfs://*ISO_DOMAIN - '*' marks host as iso domain, query location from server. nfs://host/path - bypass engine, put image directly at path. ssh://host/path - bypass engine, put image directly at path. Configuration file netrc=<file> default:~/.netrc engine=<url> ssh-key=<file> Password prompt If URL is missing password and password is not provided within netrc BENEFITS 1. Using URL notation to provide locations obsoletes the need to specify protocol, host, port, user, password, path. It is standard notation known by target audience. 2. Using well formed command: utility command source... destination is commonly used for transfers. 3. Using standard netrc notation to provide host credentials is better than proprietary format. 4. Using options as name=value provides the ability to extend configuration without altering the command-line usage.