Bug 862496

Summary: [WebTrans] concurrent user editing detection should only need TransUnitId
Product: [Retired] Zanata Reporter: Patrick Huang <pahuang>
Component: PerformanceAssignee: Patrick Huang <pahuang>
Status: CLOSED CURRENTRELEASE QA Contact: Ding-Yi Chen <dchen>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: developmentCC: sflaniga
Target Milestone: ---   
Target Release: 2.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 2.0.3-SNAPSHOT (20121108-0033) Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-02-26 03:46:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Patrick Huang 2012-10-03 04:34:06 UTC
Description of problem:
[DEV] only!
At the moment for each user in same workspace, we publish user's selected translation unit and broadcast the event to the whole workspace domain. This is to be able to detect concurrent editing of same translation by multiple users. However what we really need to broadcast is just the translation unit's id not the whole object. 

Version-Release number of selected component (if applicable):
2.0 and below

How reproducible:
n/a

Steps to Reproduce:
n/a
  
Actual results:
entire translation unit is broadcasted and wasted bandwidth and memory. 

Expected results:
only broadcast translation unit id.

Additional info:
@see org.zanata.webtrans.server.TranslationWorkspace
@see org.zanata.webtrans.shared.rpc.TransUnitEdit
@see org.zanata.webtrans.server.TranslationWorkspaceImpl
@see org.zanata.webtrans.shared.model.PersonSessionDetails

Comment 1 Patrick Huang 2012-11-05 23:57:45 UTC
committed into master:
https://github.com/zanata/zanata/commit/c90605c2e7d8702e6206bcaace89d4c64e9061bd

Comment 2 Ding-Yi Chen 2012-11-08 00:57:52 UTC
Change seems reasonable and it does not break the system.
VERIFIED with Zanata version 2.0.3-SNAPSHOT (20121108-0033)