Bug 863403

Summary: FTBFS: failing in building in %check with wrong CFLAGS
Product: [Fedora] Fedora Reporter: Matěj Cepl <mcepl>
Component: http-parserAssignee: T.C. Hollingsworth <tchollingsworth>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: lkundrak, mcepl, mcepl, tchollingsworth
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-01-11 23:29:54 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
suggested patch none

Description Matěj Cepl 2012-10-05 11:38:54 UTC 
Created attachment 622120 [details]
suggested patch

Description of problem:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4562219

+ make -j4 'CC=gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic -fsigned-char -fPIC' test
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic -fsigned-char -fPIC -O0 -g -Wall -Wextra -Werror -I. -c http_parser.c -o http_parser_g.o
gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic -fsigned-char -fPIC -O0 -g -Wall -Wextra -Werror -I. -c test.c -o test_g.o
In file included from /usr/include/sys/types.h:25:0,
                 from ./http_parser.h:30,
                 from http_parser.c:21:
/usr/include/features.h:330:4: error: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Werror=cpp]In file included from /usr/include/sys/types.h:25:0,
                 from http_parser.h:30,
                 from test.c:21:
/usr/include/features.h:330:4: error: #warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Werror=cpp]

which is caused by Makefile ignoring CFLAGS environmental variables.

There seem to be two possible ways of fixing this problem. Either fix Makefile so it doesn't ignore CFLAGS (see the attached patch which does this), or just upgrade the source to the latest master.
Comment 1 Fedora Admin XMLRPC Client 2012-10-10 13:40:57 UTC 
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.
Comment 2 T.C. Hollingsworth 2012-10-13 21:22:57 UTC 
http-parser will be updated to the latest upstream release (2.0) in Rawhide and F18.

Note that %check is still failing (and thus is disabled), but this time it's upstream's fault, not ours.  ;-)
Comment 3 Fedora Update System 2012-10-13 21:36:40 UTC 
http-parser-2.0-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/http-parser-2.0-1.fc18
Comment 4 Fedora Update System 2012-10-14 20:10:34 UTC 
Package http-parser-2.0-1.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing http-parser-2.0-1.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-16101/http-parser-2.0-1.fc18
then log in and leave karma (feedback).
Comment 5 T.C. Hollingsworth 2012-11-27 23:34:55 UTC 
Status updates:

Upstream has fixed the original test failure but now there seems to be a buffer overflow related to %optflags addition of FORTIFY_SOURCE:
https://github.com/joyent/http-parser/issues/136
Comment 6 Fedora Update System 2012-11-28 02:06:13 UTC 
Package http-parser-2.0-2.20121110git245f6f0.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing http-parser-2.0-2.20121110git245f6f0.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-16101/http-parser-2.0-2.20121110git245f6f0.fc18
then log in and leave karma (feedback).
Comment 7 Fedora Update System 2012-12-03 21:38:46 UTC 
Package http-parser-2.0-3.20121128gitcd01361.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing http-parser-2.0-3.20121128gitcd01361.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-16101/http-parser-2.0-3.20121128gitcd01361.fc18
then log in and leave karma (feedback).
Comment 8 Fedora Update System 2013-01-11 23:29:56 UTC 
http-parser-2.0-3.20121128gitcd01361.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.