Bug 863437
| Summary: | Review Request: webrtc-audio-processing - echo cancellation for Pulse Audio | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christian Fredrik Kalager Schaller <cschalle> |
| Component: | Package Review | Assignee: | Yanko Kaneti <yaneti> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | cbm, cschalle, debarshir, notting, package-review, yaneti |
| Target Milestone: | --- | Flags: | yaneti:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-10-09 15:57:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Christian Fredrik Kalager Schaller
2012-10-05 13:29:20 UTC
Thought I should also link to the upstream project: http://www.freedesktop.org/software/pulseaudio/webrtc-audio-processing/ ...reviewing the updated spec which doesn't match the SRPM because the srpm wasn't updated... License matches. Source matches upstream. Name seems reasonable. Doesn't conflict with anything existing. Library versioned reasonably. Include files unique and separate enough. - You should add the PATENTS files to %doc - There is a stray "i" on the first description line, please remove APPROVED Builds in mock. rpmmlint.. webrtc-audio-processing.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/webrtc-audio-processing-0.1/AUTHORS webrtc-audio-processing-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 2 warnings. ..harmless ok, two suggested fixes included. Will proceed with getting this packaged during the weekend. Thanks for the quick review. New Package SCM Request ======================= Package Name: webrtc-audio-processing Short Description: Echo cancellation module for PulseAudio and others Owners: uraeus, rishi Branches: f17,f18 InitialCC: bpebble, rdieter Updated SRPM to match current spec file "bpebble" is not a valid account name. No matter, Brian can add himself later on. Please go ahead and create the module without him on the cc list. New Package SCM Request ======================= Package Name: webrtc-audio-processing Short Description: Echo cancellation module for PulseAudio and others Owners: uraeus rishi Branches: f17 f18 InitialCC: bpepple rdieter Git done (by process-git-requests). Already done. |