Bug 864003

Summary: no feedback when starting uninstalled remote-viewer
Product: Red Hat Enterprise Virtualization Manager Reporter: Tomas Jamrisko <tjamrisk>
Component: ovirt-engine-userportalAssignee: Nobody <nobody>
Status: CLOSED WONTFIX QA Contact: Pavel Stehlik <pstehlik>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.1.0CC: bsettle, cfergeau, dblechte, ecohen, gklein, michal.skrivanek, pvine, rbalakri, Rhev-m-bugs, tjamrisk, uril, yeylon
Target Milestone: ---   
Target Release: 3.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: virt
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-09-07 06:32:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Tomas Jamrisko 2012-10-08 10:17:45 UTC
Description of problem:
Uninstalling virt-viewer binary on windows 7 client using Add/Remove and later trying to connecting to a VM from User Portal results in a pretty much silent failure

Version-Release number of selected component (if applicable):
rhevm-spice-client-x64-cab-3.1-4.el6

How reproducible:
Always


Steps to Reproduce:
1. Install remove-viewer through rhevm
2. remove virt-viewer using Add/Remove software in windows
3. Try connecting to a VM from User Portal
  
Actual results:
Nothing happens 

Expected results:
a) installer should start
b) user should be notified, that remote-viewer is not installed

Comment 1 Uri Lublin 2012-10-22 08:30:09 UTC
Do you keep internet-explorer running while removing virt-viewer (in 2 and 3) ?
What happens if you don't (close internet-explorer as step 1.5) ?
Anything important in spice-x log file ?

Comment 2 Tomas Jamrisko 2012-10-23 13:15:36 UTC
Yes, IE has to be running while virt-viewer is uninstalled, it locks SpiceX.dll, which doesn't then doesn't get removed. 

It works just fine with IE closed. 

Logs of SpiceX show just that cpicec wasn't found.

Comment 3 Marc-Andre Lureau 2013-05-15 21:27:26 UTC
If the activex would take the "VirtViewerMutex" that would prevent uninstaller from kicking in

Comment 5 Marc-Andre Lureau 2014-02-18 16:55:19 UTC
Either use the mutex solution proposed in #3 could work or
 
Perhaps removing /REBOOTOK from nsis script will be enough to inform user that activex uninstall wasn't successfull.

Atm. a reboot should be is easy enough to solve the problem.

The obvious solution is to stop using and supporting activex...

Comment 6 Marc-Andre Lureau 2014-02-18 16:59:59 UTC
Tomas, don't you get an error from portal after it calls Connect() ? Isn't that enough to investigate error then from the log?

Comment 7 Tomas Jamrisko 2014-03-07 10:26:06 UTC
The portal (3.3) doesn't report any error. Events tab for the VM do not indicate any problem either -- green tick with "user initiated console session". 

The only error that is logged is by spicex:
'1394187322 ERROR [3352:3392] COSpiceX::Connect: Failed to run spicec (C:\WINDOWS\Downloaded Program Files\spicec.exe --controller) -- 2'

I think that an error like that should be somewhat more visible -- at least no green tick in portal...

Comment 8 Marc-Andre Lureau 2014-03-07 11:33:11 UTC
(In reply to Tomas Jamrisko from comment #7)
> The portal (3.3) doesn't report any error. Events tab for the VM do not
> indicate any problem either -- green tick with "user initiated console
> session". 
> 
> The only error that is logged is by spicex:
> '1394187322 ERROR [3352:3392] COSpiceX::Connect: Failed to run spicec
> (C:\WINDOWS\Downloaded Program Files\spicec.exe --controller) -- 2'
> 
> I think that an error like that should be somewhat more visible -- at least
> no green tick in portal...

The error is returned from the Connect() method. I think this is a portal issue. Could someone confirm that portal is not catching errors/exceptions of Connect()?

Comment 10 Michal Skrivanek 2014-08-22 12:28:22 UTC
didn't get to it
i'd like to mention again the last line in comment #5 :-)

Comment 11 Michal Skrivanek 2015-09-07 06:32:49 UTC
we're phasing out activex as much as we can, it is still supported, but we won't be able to fix this in 3.6 timeframe, and in the next release we'll hopefully get rid of it - so closing the bug...