Bug 864028
| Summary: | fence_na does not support action=metadata via stdin | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marek Grac <mgrac> | ||||
| Component: | fence-agents | Assignee: | Marek Grac <mgrac> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | urgent | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | rawhide | CC: | abeekhof, cluster-maint, djansa, dyasny, fdinitto, jpokorny, mgrac | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | fence-agents-4.0.0-1.fc19 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | 837174 | Environment: | |||||
| Last Closed: | 2013-03-11 15:32:07 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 837174, 864030 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
Patch looks pretty sane to me. Unfortunately the applied patch suffers from several mistakes.
Not knowing about this upstream fix (haven't followed master branch as
there were quite massive changes but rather RHEL6), I proposed my own
version on the list [1] that also (as I can now see) also not ideal
(e.g., I missed "port"), so cannot recomment following it.
However, now better educated, I can recommend considering following
mistakes for correction:
1/ fence_na has no default action
2/ fence_na has "quiet" parameter
3/ fence_na has no "help" paramater
4/ fence_na provides also these actions:
- boot{,_all}
- fence_all
- forcedown_all
- release{,_all}
- shutdown{,all}
5/ "getopt" metadata annotation does not make sense
[1] http://www.redhat.com/archives/cluster-devel/2013-February/msg00075.html
([1] was proposed together with following patch to drop static non-generated part of cluster schema, which is now, also thanks to fence_na metadata support, reasonable change to do) partially fixed metadata output. fence_na is no longer part of fence-agents in fedora/rawhide |
Created attachment 629272 [details] Proposed patch Basic support for XML metadata output, so corosync can identify and use this fence device.