Bug 864470

Summary:	anaconda can be closed during installation
Product:	[Fedora] Fedora	Reporter:	Kamil Páral <kparal>
Component:	anaconda	Assignee:	David Shea <dshea>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	g.kaviyarasu, jonathan, stephent98, vanmeeuwen+fedora
Target Milestone:	---	Keywords:	FutureFeature
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-07-30 13:16:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	752665

Description Kamil Páral 2012-10-09 12:43:57 UTC

Description of problem:
On the GNOME LiveCD I can use super menu -> Quit (or probably even X button from the Overview mode) and anaconda is closed even during installation.

That should work before the installation begins, but during installation?? I believe anaconda should just ignore SIGTERM signals in that phase, user can then "force quit" if he really believes he wants to do that. But currently you can "kill" anaconda by pure accident and that's very wrong.

Version-Release number of selected component (if applicable):
F18 Beta TC2
anaconda 18.12

How reproducible:
always

Steps to Reproduce:
1. start installation
2. use super menu -> Quit in GNOME

Comment 1 Kamil Páral 2012-10-09 12:45:21 UTC

I'm afraid this doesn't qualify for blocker status, but it should be at least NTH.

Comment 2 Chris Lumens 2012-10-11 02:56:46 UTC

I don't know that there's a live environment agnostic way of disabling the "super menu", and I would hate to have to come up with a different fix for each live CD we make.  If you know of an idea, I'd be happy to consider it.

Disabling SIGTERM while we're writing to disk is an interesting idea that we'll have to talk over.  There's got to be some unforseen consequences of doing that.

Comment 3 Kamil Páral 2012-10-11 09:05:49 UTC

I agree it is a bad idea to make hacks to different DEs to disable their window-close capabilities. Fortunately this should be much simpler. The window might decide just to ignore the signal, whether it is SIGTERM or some GTK window-close signal (I don't know, I never worked with GTK). That is a reasonable behavior during installation and works consistently across all DEs.

There is nothing wrong on ignoring SIGINT/SIGTERM, a lot of programs do it. E.g. rpm will not quit immediately you press Ctrl+C, but first it will make the system consistent (close the database handles, release the locks etc) and only then it will quit. LibreOffice will ask you "Do you want to save the document before quitting?". Anaconda should do the same - make sure it doesn't leave the system in an inconsistent state (half installed).

If you receive such event, you can even pop up a dialog "The installation is in progress, please don't try to close the installer now". User can always kill the process, of course.

Comment 4 Fedora End Of Life 2013-12-21 09:04:54 UTC

This message is a reminder that Fedora 18 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 18. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '18'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 18's end of life.

Thank you for reporting this issue and we are sorry that we may not be 
able to fix it before Fedora 18 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior to Fedora 18's end of life.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 David Shea 2014-07-29 14:14:31 UTC

The window closing part is fixed, we already ignore SIGINT, SIGTERM is more complicated. We might be able to handle that better.

Comment 6 Kamil Páral 2014-07-30 08:38:46 UTC

Great, handling window closing was the most important in my opinion. Handling other signals is nice, but you don't usually send them by accident, I suppose. So from my POV, this bug can be closed :) Thanks.

Comment 7 David Shea 2014-07-30 13:16:08 UTC

Sounds good to me.