Bug 864786

Summary: Eager locking lk-owner decision is taken before transaction type is set
Product: [Community] GlusterFS Reporter: Pranith Kumar K <pkarampu>
Component: replicateAssignee: Pranith Kumar K <pkarampu>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: mainlineCC: gluster-bugs, jdarcy
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.4.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 865321 (view as bug list) Environment:
Last Closed: 2013-07-24 17:09:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 865321, 895528    

Description Pranith Kumar K 2012-10-10 06:39:44 UTC 
Description of problem:
Eager locking lk-owner decision is taken before transaction type is set.
Default transaction type is DATA so all transactions are treated as DATA transactions at the time of eager-locking decision.

Breakpoint 1, afr_transaction (frame=0x7f45fd7f8008, this=0x1f73e90, type=AFR_ENTRY_TRANSACTION) at afr-transaction.c:1452
1452	        afr_local_t *   local = NULL;
(gdb) n
1453	        afr_private_t * priv  = NULL;
(gdb) 
1454	        fd_t            *fd   = NULL;
(gdb) 
1456	        local = frame->local;
(gdb) 
1457	        priv  = this->private;
(gdb) 
1459		if (local->fd && priv->eager_lock &&
(gdb) 
1463			afr_set_lk_owner (frame, this, frame->root);
(gdb) p local->transaction.type 
$1 = AFR_DATA_TRANSACTION

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Vijay Bellur 2012-10-11 02:11:40 UTC 
CHANGE: http://review.gluster.org/4053 (cluster/afr: check transaction type for eager-lock after it is set) merged in master by Anand Avati (avati)