Bug 865321

Summary: Eager locking lk-owner decision is taken before transaction type is set
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: Pranith Kumar K <pkarampu>
Component: glusterfsAssignee: Pranith Kumar K <pkarampu>
Status: CLOSED CURRENTRELEASE QA Contact: spandura
Severity: high Docs Contact:
Priority: high    
Version: unspecifiedCC: gluster-bugs, grajaiya, jdarcy, rhinduja, rhs-bugs, vbellur
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.4.0qa4-1.el6rhs,glusterfs-3.3.0.5rhs-40.el6rhs Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 864786 Environment:
Last Closed: 2015-08-10 07:45:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 864786    
Bug Blocks:    

Description Pranith Kumar K 2012-10-11 08:41:25 UTC 
+++ This bug was initially created as a clone of Bug #864786 +++

Description of problem:
Eager locking lk-owner decision is taken before transaction type is set.
Default transaction type is DATA so all transactions are treated as DATA transactions at the time of eager-locking decision.

Breakpoint 1, afr_transaction (frame=0x7f45fd7f8008, this=0x1f73e90, type=AFR_ENTRY_TRANSACTION) at afr-transaction.c:1452
1452	        afr_local_t *   local = NULL;
(gdb) n
1453	        afr_private_t * priv  = NULL;
(gdb) 
1454	        fd_t            *fd   = NULL;
(gdb) 
1456	        local = frame->local;
(gdb) 
1457	        priv  = this->private;
(gdb) 
1459		if (local->fd && priv->eager_lock &&
(gdb) 
1463			afr_set_lk_owner (frame, this, frame->root);
(gdb) p local->transaction.type 
$1 = AFR_DATA_TRANSACTION

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

--- Additional comment from vbellur on 2012-10-10 22:11:40 EDT ---

CHANGE: http://review.gluster.org/4053 (cluster/afr: check transaction type for eager-lock after it is set) merged in master by Anand Avati (avati)
Comment 3 spandura 2013-01-07 06:26:39 UTC 
Pranith, can you please provide the steps to verify this bug.