Bug 865400
| Summary: | wallaby add-param bad error message when must-change and default value is used | ||
|---|---|---|---|
| Product: | Red Hat Enterprise MRG | Reporter: | Lubos Trilety <ltrilety> |
| Component: | wallaby-utils | Assignee: | grid-maint-list <grid-maint-list> |
| Status: | CLOSED WONTFIX | QA Contact: | MRG Quality Engineering <mrgqe-bugs> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 2.2 | CC: | esammons, iboverma, ltrilety, matt, sgraf, willb |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-05-26 20:20:11 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Wallaby references: http://getwallaby.com/ https://github.com/getwallaby/wallaby We are interested in: 1] propose patch that fixes the issue 2] propose new unittests or modification of already existing unittests that covers your changes (see GIT repository) 3] propose human testing scenario down to individual steps 4] automate testing scenario (from 3]) using python or java In case you struggle you can: - join IRC channel #distcomp on http://freenode.net/ - ask here in Bugzilla using comment field - ask on mailing list http://lists.getwallaby.com/listinfo.cgi/dev-getwallaby.com MRG-Grid is in maintenance and only customer escalations will be considered. This issue can be reopened if a customer escalation associated with it occurs. |
Description of problem: When 'wallaby add-param' is run with '--must-change yes' and some default value set it prints on RHEL5 following output: # wallaby add-param P --level -1 --description hmm --default-val val --needs-restart no --kind some --must-change yes Adding the following parameter: P with {:level=>-1, :description=>"hmm", :default_val=>"val", :needsRestart=>false, :kind=>"some", :must_change=>true} Console Connection Established... Couldn't create parameter P (Can't set must_change on a parameter with a default value (remove it first): P) From the output it seems that the parameter is not created but that's not true. # wallaby show-param P Console Connection Established... P kind: "some" default: "val" description: "hmm" must_change: false requires_restart: false visibility_level: 255 depends: [] conflicts: [] On RHEL6 no error appears, it just creates parameter P without default value. Notice the difference, on RHEL5 it creates the parameter without must-change set to on. # wallaby show-param P Console Connection Established... P kind: "some" default: "" description: "hmm" must_change: true requires_restart: false visibility_level: 255 depends: [] conflicts: [] Version-Release number of selected component (if applicable): wallaby-0.16.0-9 How reproducible: 100% Actual results: Error message, which could be badly interpreted. Expected results: Error or warning message that the default value or must-change will not be used. The same parameter created on both RHEL5 and RHEL6. Additional info: Similar issue for level -1. On RHEL6 64bit it prints: Couldn't create parameter P (integer 9223372036854775807 too small to convert to `unsigned int') However again the parameter is created and the level is set to 0, on other systems there are no errors and creates the parameter with level set to 255.