Bug 865535

Just a quick comment: Please remove the upstream egg-info so that it gets rebuild.

Thanks, Mario.  New release with just that fix added.

Spec URL: http://threebean.org/rpm/python-datanommer-models.spec
SRPM URL: http://threebean.org/rpm/python-datanommer-models-0.2.0-2.fc18.src.rpm

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4585874

$ rpmlint -i -v *
python-datanommer-models.src: I: checking
python-datanommer-models.src: I: checking-url http://pypi.python.org/pypi/datanommer.models (timeout 10 seconds)
python-datanommer-models.src: I: checking-url http://pypi.python.org/packages/source/d/datanommer.models/datanommer.models-0.2.0.tar.gz (timeout 10 seconds)
python-datanommer-models.noarch: I: checking
python-datanommer-models.noarch: I: checking-url http://pypi.python.org/pypi/datanommer.models (timeout 10 seconds)
python-datanommer-models.spec: I: checking-url http://pypi.python.org/packages/source/d/datanommer.models/datanommer.models-0.2.0.tar.gz (timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

No issues.

---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual license.
    GPLv3+
[+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
    $ sha256sum *
    57f9486bea0c3854e6ca8dbdb454737bff6ab54083f1264795eacab6bd527d33  datanommer.models-0.2.0.tar.gz
    57f9486bea0c3854e6ca8dbdb454737bff6ab54083f1264795eacab6bd527d33  datanommer.models-0.2.0.tar.gz.orig

[+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)
[+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity).
[+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: Development files must be in a -devel package.
[.] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release}
[.] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation.
[+] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time.
[.] MUST: All filenames in rpm packages must be valid UTF-8.


[.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[.] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available.
[+] SHOULD: The reviewer should test that the package builds in mock.
    See Koji build above (which uses Mock anyway).
[+] SHOULD: The package should compile and build into binary rpms on all supported architectures.
[.] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity.
[.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency.
[.] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself.
[.] SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense.



Still two objections:

The CFLAGS definition is useless here, we don't have any C code.

This package is a split-out from datanommer. It's only defined that it conflicts with that. This would mean that somebody can install datanommer *or* python-datanommer-models. But isn't it the successor of datanommer? To have a clean upgrade path, I would use the following instead:

Obsoletes:   datanommer < 0.2.0
Provides:    datanommer

The latter is for making rpmlint happy, but not really necessary in my mind, because we get more than one package which will obsolete it.
The same you could do for the other (upcoming) splitouts of datanommer.

(In reply to comment #3) 
> Still two objections:
> 
> The CFLAGS definition is useless here, we don't have any C code.
> 
> This package is a split-out from datanommer. It's only defined that it
> conflicts with that. This would mean that somebody can install datanommer
> *or* python-datanommer-models. But isn't it the successor of datanommer? To
> have a clean upgrade path, I would use the following instead:
> 
> Obsoletes:   datanommer < 0.2.0
> Provides:    datanommer
> 
> The latter is for making rpmlint happy, but not really necessary in my mind,
> because we get more than one package which will obsolete it.
> The same you could do for the other (upcoming) splitouts of datanommer.


Here's a new release that has the CFLAGS definition removed.

Regarding the Conflicts/Obsoletes/Provides, I'd like to still maintain the datanommer package itself as a kind of meta-package that installs the splitoffs but also includes "fedmsg-hub" which will turn on a new service.  Once these packages are approved, I would bump the datanommer meta package from 0.1.8 to 0.2.0 to match them.  Do you think that would be okay?

Spec URL: http://threebean.org/rpm/python-datanommer-models.spec
SRPM URL: http://threebean.org/rpm/python-datanommer-models-0.2.0-3.fc18.src.rpm

@Ralph, there's a thread in the packaging mailing list about this review [1]. Please have a look at it.

[1] http://lists.fedoraproject.org/pipermail/packaging/2012-October/008710.html

New release removes Conflicts tag with the old datanommer.   Rely on the implicit file conflict instead of an explicit versioned package conflict.

Spec URL: http://threebean.org/rpm/python-datanommer-models.spec
SRPM URL: http://threebean.org/rpm/python-datanommer-models-0.2.0-4.fc18.src.rpm

Mario, I thought I wrote a note to the list but it must have gotten lost in the tubes.. perhaps queued for moderation?

Either way, do you think my removal of the explicit Conflicts tag is acceptable?

(In reply to comment #7)
> Mario, I thought I wrote a note to the list but it must have gotten lost in
> the tubes.. perhaps queued for moderation?
> 
> Either way, do you think my removal of the explicit Conflicts tag is
> acceptable?

I think it's OK. Well, not really canonical, but I hope you will deprecate datanommer in the foreseeable future ;)

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4663561


$ rpmlint -i -v *
python-datanommer-models.src: I: checking
python-datanommer-models.src: I: checking-url http://pypi.python.org/pypi/datanommer.models (timeout 10 seconds)
python-datanommer-models.src: I: checking-url http://pypi.python.org/packages/source/d/datanommer.models/datanommer.models-0.2.0.tar.gz (timeout 10 seconds)
python-datanommer-models.noarch: I: checking
python-datanommer-models.noarch: I: checking-url http://pypi.python.org/pypi/datanommer.models (timeout 10 seconds)
python-datanommer-models.spec: I: checking-url http://pypi.python.org/packages/source/d/datanommer.models/datanommer.models-0.2.0.tar.gz (timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

No issues.


---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual license.
    GPLv3+
[+] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
    $ sha256sum *
    57f9486bea0c3854e6ca8dbdb454737bff6ab54083f1264795eacab6bd527d33  datanommer.models-0.2.0.tar.gz
    57f9486bea0c3854e6ca8dbdb454737bff6ab54083f1264795eacab6bd527d33  datanommer.models-0.2.0.tar.gz.orig

[+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)
[+] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity).
[+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: Development files must be in a -devel package.
[.] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release}
[.] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation.
[+] MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time.
[+] MUST: All filenames in rpm packages must be valid UTF-8.


[.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it.
[.] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available.
[+] SHOULD: The reviewer should test that the package builds in mock.
    See Koji build above (which uses Mock anyway).
[.] SHOULD: The package should compile and build into binary rpms on all supported architectures.
[.] SHOULD: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example.
[.] SHOULD: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity.
[.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency.
[.] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself.
[.] SHOULD: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense.

----------------

PACKAGE APPROVED

----------------

I will!  (just have to wait on https://bugzilla.redhat.com/show_bug.cgi?id=865536 and https://bugzilla.redhat.com/show_bug.cgi?id=865538 ) :)

Thanks Mario!

New Package SCM Request
=======================
Package Name: python-datanommer-models
Short Description: SQLAlchemy models for datanommer
Owners: ralph
Branches: f18 f17 el6
InitialCC:

Git done (by process-git-requests).

python-datanommer-models-0.2.0-6.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-datanommer-models-0.2.0-6.el6

python-datanommer-models-0.2.0-6.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/python-datanommer-models-0.2.0-6.fc18

python-datanommer-models-0.2.0-6.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/python-datanommer-models-0.2.0-6.fc17

python-datanommer-models-0.2.0-6.fc18 has been pushed to the Fedora 18 testing repository.

datanommer-0.2.0-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/datanommer-0.2.0-2.fc18

datanommer-0.2.0-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/datanommer-0.2.0-2.fc17

python-datanommer-models-0.2.0-6.el6 has been pushed to the Fedora EPEL 6 stable repository.

datanommer-0.2.0-2.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

python-datanommer-models-0.2.0-6.fc17 has been pushed to the Fedora 17 stable repository.

python-datanommer-models-0.2.0-6.fc17 has been pushed to the Fedora 17 stable repository.

datanommer-0.2.0-2.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.