Bug 865997

Summary: Review Request: caledonia-kde-theme - a dark theme for KDE plasma
Product: [Fedora] Fedora Reporter: Brendan Jones <brendan.jones.it>
Component: Package ReviewAssignee: Jørn Lomax <northlomax>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: northlomax, notting, package-review
Target Milestone: ---Flags: northlomax: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-11-19 04:26:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 805236    

Description Brendan Jones 2012-10-13 06:56:10 UTC
This is a dark theme for KDE plasma

SRPM: http://bsjones.fedorapeople.org/caledonia-kde-theme-1.2.0-1.fc18.src.rpm
SPEC: http://bsjones.fedorapeople.org/caledonia-kde-theme.spec


caledonia-kde-theme.src: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out
caledonia-kde-theme.noarch: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out
2 packages and 0 specfiles checked; 0 errors, 2 warnings

Comment 1 Jørn Lomax 2012-10-28 13:07:39 UTC
The fedora-review script is failing me a little on this one, so i'm going through the steps manually.


$ rpmlint caledonia-kde-theme-1.2.0-1.fc17.noarch.rpm 
caledonia-kde-theme.noarch: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint caledonia-kde-theme-1.2.0-1.fc17.src.rpm 
caledonia-kde-theme.src: W: spelling-error %description -l en_US logout -> lo gout, lo-gout, log out
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

$ rpmlint caledonia-kde-theme.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

No problems there

great to see in the .spec where the  licence can be found.
The licence checks out (from the README FILE):

[...]
Some rights reserved. This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License.


It builds cleanly, no issues found in the build log, and it installs locally without any issues. No issues found in the mock build log either

Great package!

*****************
PACKAGE APPROVED*
*****************

Comment 2 Brendan Jones 2012-10-28 15:41:12 UTC
Thanks for the review!

New Package SCM Request
=======================
Package Name: caledonia-kde-theme
Short Description: Desktop theme for plasma
Owners: bsjones
Branches:f16 f17 f18
InitialCC:

Comment 3 Gwyn Ciesla 2012-10-28 20:44:29 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2012-10-28 21:23:11 UTC
caledonia-kde-theme-1.2.0-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/caledonia-kde-theme-1.2.0-1.fc18

Comment 5 Fedora Update System 2012-10-28 21:35:29 UTC
caledonia-kde-theme-1.2.0-1.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/caledonia-kde-theme-1.2.0-1.fc17

Comment 6 Fedora Update System 2012-10-28 21:35:40 UTC
caledonia-kde-theme-1.2.0-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/caledonia-kde-theme-1.2.0-1.fc16

Comment 7 Fedora Update System 2012-10-29 18:15:20 UTC
caledonia-kde-theme-1.2.0-1.fc18 has been pushed to the Fedora 18 testing repository.