Bug 866370
| Summary: | Review Request: php-channel-theseer - Adds theseer channel to PEAR | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||
| Component: | Package Review | Assignee: | Johan Cwiklinski <fedora> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora, notting, package-review | ||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-12-20 15:22:54 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 866428 | ||||||
| Attachments: |
|
||||||
|
Description
Remi Collet
2012-10-15 08:38:04 UTC
Created attachment 630488 [details]
fedora review output
Package builds fine in mock.
rpmlint output:
php-channel-theseer.noarch: W: spelling-error %description -l en_US netpirates -> net pirates, net-pirates, penetrates
php-channel-theseer.noarch: W: no-documentation
php-channel-theseer.src: W: spelling-error %description -l en_US netpirates -> net pirates, net-pirates, penetrates
php-channel-theseer.src:24: W: unversioned-explicit-provides php-channel(%{channel})
All of those warnings can be ignored.
Require issues pointed in fedora-review output is false positive, the licencing issue can be ignored, as weel as the missing %{name} prefix in Source0.
The package respects php pear channel packaging guidelines.
APPROVED.
Thanks for the review. New Package SCM Request ======================= Package Name: php-channel-theseer Short Description: Adds theseer channel to PEAR Owners: remi Branches: f17 f18 el6 InitialCC: Git done (by process-git-requests). php-channel-theseer-1.3-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-channel-theseer-1.3-1.el6 php-channel-theseer-1.3-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-channel-theseer-1.3-1.fc18 php-channel-theseer-1.3-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-channel-theseer-1.3-1.fc17 php-channel-theseer-1.3-1.el6 has been pushed to the Fedora EPEL 6 testing repository. php-channel-theseer-1.3-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |