Bug 866491

Summary: Error handling needed repo copy rpm when --to-repo-id/from-repo-id doesn't exist
Product: [Retired] Pulp Reporter: Preethi Thomas <pthomas>
Component: user-experienceAssignee: Jay Dobies <jason.dobies>
Status: CLOSED CURRENTRELEASE QA Contact: Preethi Thomas <pthomas>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 2.0.6CC: skarmark
Target Milestone: ---Keywords: Triaged
Target Release: Sprint 42   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-01-09 17:05:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Preethi Thomas 2012-10-15 13:44:12 UTC
Description of problem:

When you use non existing repo-id for for --to-repo-id/from-repo-id  for repo copy, it will look like its copying but the missing resource error can be traced in the log
Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:

[root@pulp-master ~]# pulp-admin rpm repo copy rpm --from-repo-id pulp-f17 --to-repo-id dest -d --match "name=^p.*" --match "arch=noarch"
Progress on this task can be viewed using the commands under "repo tasks".

[root@pulp-master ~]# pulp-admin tasks list
+----------------------------------------------------------------------+
                                 Tasks
+----------------------------------------------------------------------+

Operations:  associate
Resources:   dest (repository), pulp-f17 (repository)
State:       Failed
Start Time:  Unstarted
Finish Time: 2012-10-15T13:20:20Z
Result:      Incomplete
Task Id:     11d3154a-16cb-11e2-8d27-54520075d18e



1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Jay Dobies 2012-11-28 20:07:21 UTC
Changed to run the repo validation before the task is kicked off:

╭─[jdob]─[hinterlands]─[~]─[]─●
╰─➤ pulp-admin rpm repo copy rpm --to-repo-id fake --from-repo-id test-repo
The following resource(s) could not be found:

  fake (repo_id)


╭─[jdob]─[hinterlands]─[~]─[]─●
╰─➤ pulp-admin rpm repo copy rpm --to-repo-id test-repo --from-repo-id fake
The following resource(s) could not be found:

  fake (repo_id)

Comment 2 Jay Dobies 2012-11-28 20:45:18 UTC
Correction, it's not REST-y to say the source repo is missing, so instead it will indicate bad data, which will look like:


╭─[jdob]─[hinterlands]─[~]─[]─●
╰─➤ pulp-admin rpm repo copy rpm --to-repo-id test-repo --from-repo-id fake
The values for the following properties were invalid: from-repo-id

Comment 3 Jay Dobies 2012-11-28 20:59:37 UTC
Git Commits:

Pulp:412564388f1946e1724902f9811f7224ceb1eeab
     7560ec3a45410d34ca8554f6390f66b9265da99a
Pulp RPM: 2a37f5272d712a82fa98b868f44611948a07e6a0
Pulp Puppet: ad7d365b1a737f1a326e6d4d077da7771e0d0e4d

Comment 4 Jeff Ortel 2012-11-29 21:30:12 UTC
build: 2.0.6-0.10.beta

Comment 5 Preethi Thomas 2012-12-04 01:51:25 UTC
[root@preethi-el6-pulp ~]# rpm -q pulp-server
pulp-server-2.0.6-0.11.beta.noarch
[root@preethi-el6-pulp ~]# 


[root@preethi-el6-pulp ~]# pulp-admin repo list
+----------------------------------------------------------------------+
                              Repositories
+----------------------------------------------------------------------+

Id:                 zoo1
Display Name:       zoo1
Description:        None
Content Unit Count: 39

Id:                 zoo
Display Name:       zoo
Description:        None
Content Unit Count: 39

[root@preethi-el6-pulp ~]# rpm -q pulp-server
pulp-server-2.0.6-0.11.beta.noarch
[root@preethi-el6-pulp ~]# 

[root@preethi-el6-pulp ~]# pulp-admin rpm repo copy rpm --to-repo-id fake --from-repo-id zoo
The following resource(s) could not be found:

  fake (repo_id)


[root@preethi-el6-pulp ~]# pulp-admin tasks list
+----------------------------------------------------------------------+
                                 Tasks
+----------------------------------------------------------------------+

Operations:  
Resources:   
State:       Failed
Start Time:  Unstarted
Finish Time: 2012-12-03T19:46:05Z
Result:      Incomplete
Task Id:     5a93d536-55a6-4497-8a23-a1ef88e6e5fc


[root@preethi-el6-pulp ~]# pulp-admin rpm repo copy rpm --to-repo-id zoo --from-repo-id fake
The values for the following properties were invalid: from-repo-id

Comment 6 Preethi Thomas 2013-01-09 17:05:30 UTC
Pulp v2.0 released