Bug 868266

Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4606622

I'll take this review.  My initial attempt at using fedora-review is failing for reasons I don't understand.  The initial build succeeds, but then it does this:

Installing built package(s)
Mock command returned error code 1
Cannot run mock --shell rpmbuild -bp: INFO: mock.py version 1.1.29 starting...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Start: lock buildroot
Start: device setup
Finish: device setup
Start: shell
Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.pAn4Ho
+ umask 022
+ cd /builddir/build/BUILD
+ cd /builddir/build/BUILD
+ rm -rf pyglet-1.2alpha1
+ /usr/bin/gzip -dc /builddir/build/SOURCES/pyglet-1.2alpha1-repacked.tar.gz
+ /usr/bin/tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd pyglet-1.2alpha1
+ /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ find . -name '*.py'
+ xargs dos2unix
xargs: dos2unix: No such file or directory
error: Bad exit status from /var/tmp/rpm-tmp.pAn4Ho (%prep)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.pAn4Ho (%prep)
Finish: shell
Finish: lock buildroot

... which makes no sense at all, since the spec file BuildRequires: dos2unix.  I'll see if I can figure out what is going on.

FWIW, dos2unix isn't necessary anyway.  You're already using sed on all of the source files, so you might as well make it do the extra work.  I replaced the two lines in %prep starting with "find" with this:

# Get rid of hashbang lines. This is a library, it has no executable scripts.
# Also remove Windows newlines
find . -name '*.py' | xargs sed -i -e 's|#!/usr/bin/\(env \)\?python||;s/\r//'

and now fedora-review likes it.  I don't know that there is anything wrong with the original; it is probably a bug in mock.  But this lets me move forward with the review (and the dos2unix BR can be removed).

I don't think pypng should be bundled.  The pure Python version runs several times more slowly than the version that uses a C interface.  I took a look at how hard it would be to package, and it doesn't look too bad.  Here's how I did it:

http://jjames.fedorapeople.org/pypng/

If you want to own that package, feel free to take what I did and replace my changelog entry in the spec file with your own.  Seriously.  If you don't want to own it, let me know; I may be willing.

Thanks for reviewing!

Packaging pypng is one thing, but pyglet's copy changed since it was forked, and the upstream (with a new maintainer) has also changed extensively. I'll try to see if I can make them work together.

I'll also try to get PyPNG upstream to include a proper license, as it seems only png.py has license text; then I'll request a review.

Ah, I didn't realize we are dealing with a forked pypng here.  Are the changes such that pypng upstream might possibly be interested in them?

Not likely, the fork uses pyglet's modules.
Looking at them again, though, they are mostly efforts to port to Python 3. Given that pypng upstream supports Python 3, it might be possible to use the upstream version after all.

I'll test while waiting on pypng to clear the licensing.

I'm looking at the older reviews and there was a problem with patented S3TC. Is that no longer a problem in the package reviewed here?

https://bugzilla.redhat.com/show_bug.cgi?id=468298#c18

No, it's removed from the trarball, disabling support for DirectX texture files.

More details are in the SRPM, or look here:
curl http://fedorapeople.org/~pviktori/rpms/pyglet-get-tarball.sh

Unfortunately, upstream pypng is not usable with pyglet, there are API changes.

A viable workaround is to remove the pypng plugin, and depend on python-imaging to provide the PNG support. It's faster, it supports more formats, but it's an additional (and less portable) dependency.
I've updated the package to do that.

Here are the updated files:
Spec URL: http://fedorapeople.org/~pviktori/rpms/pyglet.spec
SRPM URL: http://fedorapeople.org/~pviktori/rpms/pyglet-1.2-0.2.alpha1.fc18.src.rpm

Rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5259868

Hmmm, but python-imaging has been dropped from F-19 and Rawhide in favor of python-pillow.  Can pyglet be made to work with python-pillow, and does it have the same advantages?

Yes. Here are updated files:

Spec URL: http://fedorapeople.org/~pviktori/rpms/pyglet.spec
SRPM URL: http://fedorapeople.org/~pviktori/rpms/pyglet-1.2-0.3.alpha1.fc18.src.rpm

The only issue that I see is the license tag.  Shouldn't it be just "BSD" now that pypng is not bundled?  Also, this is not required, but have you considered also building a python3 version?  The package seems to support that.

Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "BSD (3 clause)", "BSD (3 clause) MIT/X11 (BSD like)", "Unknown or
     generated". 3 files have unknown license. Detailed output of licensecheck
     in /home/jamesjer/868266-pyglet/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
     names).
[x]: If the package is under multiple licenses, the licensing breakdown must
     be documented in the spec.
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 40960 bytes in 5 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
     Upstream does not provide any tests
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: pyglet-1.2-0.3.alpha1.fc20.noarch.rpm
pyglet.noarch: E: explicit-lib-dependency libGL
pyglet.noarch: E: explicit-lib-dependency libX11
pyglet.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti
1 packages and 0 specfiles checked; 2 errors, 1 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint pyglet
pyglet.noarch: E: explicit-lib-dependency libGL
pyglet.noarch: E: explicit-lib-dependency libX11
pyglet.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti
1 packages and 0 specfiles checked; 2 errors, 1 warnings.
# echo 'rpmlint-done:'



Requires
--------
pyglet (rpmlib, GLIBC filtered):
    libGL
    libX11
    python
    python(abi)
    python-pillow(x86-64)



Provides
--------
pyglet:
    pyglet



Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 868266 -m fedora-rawhide-x86_64

According to pyglet website, "These packages [1.2alpha1] are provided for testing purposes, and are not suitable for production use." I'd rather see stable 1.1.4 in stable Fedora releases. That is the version on pypi and most likely the version most apps would use nowadays.

For example my package printrun enables some features, when pyglet is present and it counts on stable version of pyglet, pyglet 1.2alpha1 simply breaks it (as it brings some backward incompatible changes) and I would need to patch printrun to not use pyglet based features even if pyglet is present.

I'm currently working with printrun upstream on supporting pyglet 1.2, but it doesn't change my opinion on this. Does pyglet have long pauses in releases? Yes it does. But is that a reason to bring possible unstable and untested versions? I don't think so.

Originally (after a discussion on a packaging workshop) I went to package the latest & greatest. But if printrun needs the 1.2 version I guess it would make sense to package that.

I should find some time for it next week.

Actually, we might not understand each other, printrun needs pyglet 1.1.4 (as a optional dependency).

I've fixed the license, and added a Python 3 build. For this I needed to rename the package to python-pyglet & python3-pyglet.

Unfortunately the Python 3 support is not really ready upstream, so I disabled it for now. In the next version should work.

Spec URL: http://fedorapeople.org/~pviktori/rpms/python-pyglet.spec
SRPM URL: http://fedorapeople.org/~pviktori/rpms/python-pyglet-1.2-0.4.alpha1.fc19.src.rpm
Koji rawhide build (includes the Python 3 package): http://koji.fedoraproject.org/koji/taskinfo?taskID=5479283

Miro:
According to the mailing list announcement (http://groups.google.com/group/pyglet-users/msg/b848b4e1fb2a059c?hl=en), the reason for not putting this on pip was to not “break people using "pip install" or similar tools”. Since pyglet-1.1.4 is not packaged for Fedora, pyglet-1.2 can't really break existing packages.
Hopefully printrun upstream can support pyglet-1.2 soon.

Taking it into account.

OK, license appears correct and I don't see any other issues.  I hope that printrun can be adapted to this version, too.  Thanks for attempting python3 support, Petr.  This package is APPROVED.

printrun-0.0-24.20130123git71e5da0.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/printrun-0.0-24.20130123git71e5da0.fc19

printrun-0.0-24.20130123git71e5da0.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/printrun-0.0-24.20130123git71e5da0.fc18

printrun-0.0-24.20130123git71e5da0.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/printrun-0.0-24.20130123git71e5da0.fc17

Package printrun-0.0-24.20130123git71e5da0.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing printrun-0.0-24.20130123git71e5da0.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-10337/printrun-0.0-24.20130123git71e5da0.fc19
then log in and leave karma (feedback).

(Sorry for messing up with the bug status)

New Package SCM Request
=======================
Package Name: python-pyglet 
Short Description: A cross-platform windowing and multimedia library for Python
Owners: pviktori
Branches: f18 f19
InitialCC:

WARNING: Requested package name python-pyglet doesn't match bug summary
pyglet, please correct.

New Package SCM Request
=======================
Package Name: python-pyglet 
Short Description: A cross-platform windowing and multimedia library for Python
Owners: pviktori
Branches: f18 f19
InitialCC:

Git done (by process-git-requests).

printrun-0.0-24.20130123git71e5da0.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.

python-pyglet-1.2-0.5.alpha1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-pyglet-1.2-0.5.alpha1.fc19

python-pyglet-1.2-0.5.alpha1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/python-pyglet-1.2-0.5.alpha1.fc18

python-pyglet-1.2-0.5.alpha1.fc18 has been pushed to the Fedora 18 testing repository.

printrun-0.0-24.20130123git71e5da0.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

printrun-0.0-24.20130123git71e5da0.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

python-pyglet-1.2-0.5.alpha1.fc18 has been pushed to the Fedora 18 stable repository.

python-pyglet-1.2-0.5.alpha1.fc19 has been pushed to the Fedora 19 stable repository.

There is a problem with F18 package of python-pyglet[*]:

Python-sympy needs png decoder in python-pyglest which is removed according to python-pyglest specs:

(...)
# Remove the bundled pypng library python-pillow provides the same functionality)
rm pyglet/image/codecs/png.py
rm pyglet/image/codecs/pypng.py
(...)

but python-pillow is never submitted in Fedora 18 repos, so png decoder doesn't work in F18 version of pyglet. Tnx.


[*] I don't know if this is a good place to put it or should I open a new bug report.

It's closed, you'd better create a new bug.

IMO this package shouldn't have this branch if things are really being as you've said.

Tnx Christopher for a really fast response. I'll still wait for Petr's answer before I open a new bug because he is a primary maintainter so he will probably need to fix it.

In the context of facts that in few months F18 will be EOL so this bug would be obsolete and this troublesome feature of SymPy is rearly used, I don't think I should open a new bug report only for the sake of formality. Let it be here only for a record but you guys can freely decide otherwise :-)

Sorry for the late response, I was on vacation last week.

Looks like I didn't test enough on f18. The fix should be easy (use python-imaging instead of Pillow on f18) but testing it will take longer.
I'll open a new bug if you don't beat me to it.

I've tested on f18 and checked that PNG images are loaded fine. On a typical desktop, the GDKPixbuf2ImageDecoder will probably get selected, but the PILImageDecoder also works. It uses python-imaging (PIL), which got replaced by python-pillow in f19. The Pyglet package does depend on python-imaging in f18.
The PNG decoder is missing, as expected.

If python-sympy really needs the PNG decoder and can't use another one that loads PNGs, then I'm sorry -- I'm not putting the bundled fork of pypng back.
The right way would be to fix Pyglet to use upstream pypng, and package pypng for Fedora (https://bugzilla.redhat.com/show_bug.cgi?id=810376). Unfortunately I don't have resources to do that any time soon.

Please open a new bug, e-mail me privately, for any further discussion.

We need this in EPEL7 for sympy.  Petr - would you be willing to maintain it there?

Well, I wouldn't mind a co-maintainer :)
But, all that'll be needed is to make with_python3 conditional, and some testing. When I have a bit of time I'll go spin up an EL7 machine and do it.


If anyone wants to help: build the package, and run events & graphics from [0] with it installed. That should test it enough.

https://bitbucket.org/pyglet/pyglet/src/cd6753287628056278d566b1cc556a41c66cf1b5/examples/?at=default

I'd be happy to comaintain.  FAS - orion

Why the use of %py_byte_compile?  I've never seen that in a package before.  Macro doesn't seem to exist on EL7.

So, with:

diff --git a/python-pyglet.spec b/python-pyglet.spec
index b08a2c4..ede83af 100644
--- a/python-pyglet.spec
+++ b/python-pyglet.spec
@@ -1,4 +1,6 @@
+%if 0%{?fedora}
 %global with_python3 1
+%endif

 %global srcname pyglet
 %global srcversion 1.2.1
@@ -102,12 +104,12 @@ popd

 %install
 %{__python} setup.py install --skip-build --root %{buildroot}
-%py_byte_compile %{__python} %{buildroot}%{python_sitelib}/%{srcname}
+%{__python} %{buildroot}%{python_sitelib}/%{srcname}

 %if 0%{?with_python3}
 pushd %{py3dir}
 %{__python3} setup.py install --skip-build --root %{buildroot}
-%py_byte_compile %{__python3} %{buildroot}%{python3_sitelib}/%{srcname}
+%{__python3} %{buildroot}%{python3_sitelib}/%{srcname}
 popd
 %endif


I end up with:

+ /usr/bin/python /builddir/build/BUILDROOT/python-pyglet-1.2.1-1.el7.x86_64/usr/lib/python2.7/site-packages/pyglet
/usr/bin/python: can't find '__main__' module in '/builddir/build/BUILDROOT/python-pyglet-1.2.1-1.el7.x86_64/usr/lib/python2.7/site-packages/pyglet'

Perhaps the %py_byte_compile was supposed to set that up?

%py_byte_compile compiles the sources to bytecode.

It's a macro from python3-devel, so it won't be on EL7, but it's given in Fedora package guidelines (https://fedoraproject.org/wiki/Packaging:Python#Macros)

You can use code like this:

%if 0%{?with_python3}
%py_byte_compile %{__python2} %{buildroot}%{python_sitelib}/%{srcname}
%else
# py_byte_compile is only defined in python3-devel
%{__python2} -m compileall %{buildroot}%{python_sitelib}/%{srcname}
%endif

You don't need to call %py_byte_compile on things in %{python_sitelib} or %{python3_sitelib}.

See https://fedoraproject.org/wiki/Packaging:Python#Bytecompiling_with_the_correct_python_version for reference.

Package Change Request
======================
Package Name: python-pyglet
New Branches: epel7
Owners: pviktori orion
InitialCC:

Git done (by process-git-requests).

Thanks Jon!

And thanks Orion for your work! I gave you commit access to all branches, but I'd like to test the change before pushing to Fedora if you don't mind.

Petr - I'll push my changes to the EPEL7 branch first.  Should be fine to push to Fedora, but I'll let you do that.