Bug 868331
Summary: | JBoss Tools: Unable to deal with embedded cartridges | ||
---|---|---|---|
Product: | OKD | Reporter: | Attila Nagy <anagy> |
Component: | Master | Assignee: | Lili Nader <lnader> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | libra bugs <libra-bugs> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 2.x | CC: | adietish, mfisher, mshao |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | devenv_2366 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-11-06 18:49:00 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Attila Nagy
2012-10-19 14:20:15 UTC
Additional note: this functionality works well in production environment. Additionally the same behavior is discovered during embedding cartridges. Steps to Reproduce #1: 1. Open OpenShift New Application Wizard: File -> New -> Other... -> OpenShift Application 2. Provide your access credentials 3. Add application name + application type + choose one of the embedded cartridges 4. Next -> Next -> Finish Steps to Reproduce #2: 1. Open OpenShift Explorer 2. Right click on the name of the application 3. Choose menu 'Edit Embedded Cartridges...' 4. Choose one of the embedded cartridges in the list 5. Click on 'Finish' I will communicate with JBoss tools team about this bug. Sent email to Jboss tools team. There's a bug related to embedding cartridges Thanks for reporting this issue. This was discovered when testing Alpha2 so I dont think that this is related to the following error in Beta1 when embedding cartridges: https://issues.jboss.org/browse/JBIDE-12864 There's a change in the REST protocol that causes this. When we request the broker to add a cartridge to an application, the broker returns the freshly crearted (and added) resource to us. When embedding mysql, the returned json could look like this: { "type" => "cartridges", "supported_api_versions" => [ big decimal 1.0, big decimal 1.1, big decimal 1.2 ], "data" => [{ "type" => "embedded", "status_messages" => undefined, "name" => "mysql-5.1", "properties" => { "username" => "admin", "connection_url" => "mysql://127.0.252.129:3306/", "info" => "Connection URL: mysql://127.0.252.129:3306/", "database_name" => "ba", "password" => "ruWyzLFih2b2" }, "links" => { "DELETE" => { ... Now the latest REST protocol apparently returns a link for an UPDATE action which holds optional parameters of type <b>"integer"</b>: "UPDATE" => { "href" => "https://ec2-107-20-102-82.compute-1.amazonaws.com/broker/rest/domains/somedomain/applications/ba/cartridges/mysql-5.1", "required_params" => [], "method" => "PUT", "optional_params" => [ { "name" => "additional_storage", "type" => "integer", ... }, { "name" => "scales_from", "type" => "integer", ... }, { "name" => "scales_to", "type" => "integer", ... } ], "rel" => "Update cartridge configuration" } These new type make the openshift-java-client fail in the unmarshalling since it's only aware of String and Boolean types so far. I'd ask you to push this change to protocol 1.1 and up since you'd otherwise break our existing clients (JBoss Tools, etc.). fixed in devenv_2366 @Lili: so what did you exactly fix? I'd appreciate some comments. so in https://github.com/lnader/origin-server/commit/73ce66d14930631f65b790bf0d5687514b7fa54e you apparently removed the integer link parameters for rest proto 1.0 (proto 1.1 in https://github.com/lnader/origin-server/blob/master/controller/lib/openshift-origin-controller/app/models/rest_cartridge11.rb still has them). So that would mean that the latest OpenShift would - in prot 1.0 - not provide the integer parameters and break the openshift-java-client, right? Verified against devenv_2372 |