Bug 869391

Summary: LUKSError: luks device has no key/passphrase
Product: [Fedora] Fedora Reporter: Reartes Guillermo <rtguille>
Component: anacondaAssignee: David Lehman <dlehman>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 18CC: awilliam, g.kaviyarasu, jonathan, mkovarik, robatino, stephent98, vanmeeuwen+fedora
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard: abrt_hash:19c5526cf0e7efeed756de1fc73e8f47a0e5edc09d4c5cdba9ab7b4522c21d47 AcceptedBlocker
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-11-08 09:14:32 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 752660    
Attachments:
Description Flags
File: anaconda-tb
none
File: product
none
File: type
none
File: ifcfg.log
none
File: storage.log
none
File: version
none
File: environ
none
File: anaconda.log
none
File: syslog
none
File: hashmarkername
none
File: packaging.log
none
File: cmdline_file
none
File: release
none
File: program.log none

Description Reartes Guillermo 2012-10-23 18:52:35 UTC
Description of problem:
i was able to start installing with an empty <null> luks password. (! wOw !)

Version-Release number of selected component:
anaconda-18.19

Additional info:
libreport version: 2.0.14
cmdline:        /usr/bin/python  /sbin/anaconda
kernel:         3.6.1-1.fc18.x86_64

description:
:The following was filed automatically by anaconda:
:anaconda 18.19 exception report
:Traceback (most recent call first):
:  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/formats/luks.py", line 189, in create
:    raise LUKSError("luks device has no key/passphrase")
:  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/deviceaction.py", line 439, in execute
:    options=self.device.formatArgs)
:  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/devicetree.py", line 323, in processActions
:    action.execute()
:  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/__init__.py", line 357, in doIt
:    self.devicetree.processActions()
:  File "/usr/lib64/python2.7/site-packages/pyanaconda/storage/__init__.py", line 195, in turnOnFilesystems
:    storage.doIt()
:  File "/usr/lib64/python2.7/site-packages/pyanaconda/install.py", line 107, in doInstall
:    turnOnFilesystems(storage)
:  File "/usr/lib64/python2.7/threading.py", line 504, in run
:    self.__target(*self.__args, **self.__kwargs)
:  File "/usr/lib64/python2.7/site-packages/pyanaconda/threads.py", line 91, in run
:    threading.Thread.run(self, *args, **kwargs)
:LUKSError: luks device has no key/passphrase

Comment 1 Reartes Guillermo 2012-10-23 18:52:48 UTC
Created attachment 632301 [details]
File: anaconda-tb

Comment 2 Reartes Guillermo 2012-10-23 18:52:51 UTC
Created attachment 632302 [details]
File: product

Comment 3 Reartes Guillermo 2012-10-23 18:52:53 UTC
Created attachment 632303 [details]
File: type

Comment 4 Reartes Guillermo 2012-10-23 18:52:56 UTC
Created attachment 632304 [details]
File: ifcfg.log

Comment 5 Reartes Guillermo 2012-10-23 18:53:02 UTC
Created attachment 632305 [details]
File: storage.log

Comment 6 Reartes Guillermo 2012-10-23 18:53:05 UTC
Created attachment 632306 [details]
File: version

Comment 7 Reartes Guillermo 2012-10-23 18:53:07 UTC
Created attachment 632307 [details]
File: environ

Comment 8 Reartes Guillermo 2012-10-23 18:53:10 UTC
Created attachment 632308 [details]
File: anaconda.log

Comment 9 Reartes Guillermo 2012-10-23 18:53:13 UTC
Created attachment 632309 [details]
File: syslog

Comment 10 Reartes Guillermo 2012-10-23 18:53:16 UTC
Created attachment 632310 [details]
File: hashmarkername

Comment 11 Reartes Guillermo 2012-10-23 18:53:18 UTC
Created attachment 632311 [details]
File: packaging.log

Comment 12 Reartes Guillermo 2012-10-23 18:53:20 UTC
Created attachment 632312 [details]
File: cmdline_file

Comment 13 Reartes Guillermo 2012-10-23 18:53:23 UTC
Created attachment 632313 [details]
File: release

Comment 14 Reartes Guillermo 2012-10-23 18:53:26 UTC
Created attachment 632314 [details]
File: program.log

Comment 15 Steve Tyler 2012-10-30 16:29:37 UTC
When prompted for a LUKS passphrase, click continue.

Package: anaconda-18.19
OS Release: Fedora release 18-Beta-TC6

Comment 16 Steve Tyler 2012-10-30 16:43:23 UTC
(In reply to comment #15)
> When prompted for a LUKS passphrase, click continue.
> 
> Package: anaconda-18.19
> OS Release: Fedora release 18-Beta-TC6

Correction: Click "Save Passphrase".

What will happen during a kickstart install, if the passphrase is empty?
Cf: Bug 868519, Comment 22.

Comment 17 Michal Kovarik 2012-11-05 08:26:31 UTC
Steps to Reproduce:
1. prepare disk without free space
2. start installation
3. on disks screen check 'Encrypt my data', click on Continue
4. Reclaim space, delete all partitions
5. begin installation

Expected:
Ask for password for encryption


Package: anaconda-18.24
OS Release: Fedora release 18-Beta-TC7

Comment 18 David Lehman 2012-11-05 16:03:36 UTC
I have patches to fix this. I'll be sending them out for review later today.

Comment 19 Adam Williamson 2012-11-05 16:58:59 UTC
Reproduced as described by Michal: if you check the 'Encrypt my data' box and then go through 'guided partitioning' to delete partitions and free up space, you are not prompted for an encryption passphrase at any point, and install crashes at the start of actual installation, when it's creating partitions.

Comment 20 Adam Williamson 2012-11-05 17:05:32 UTC
Reproduced as described by Michal: if you check the 'Encrypt my data' box and then go through 'guided partitioning' to delete partitions and free up space, you are not prompted for an encryption passphrase at any point, and install crashes at the start of actual installation, when it's creating partitions.

Discussed at 2012-11-05 QA meeting acting as a blocker review meeting. Accepted as a blocker. At present our criteria don't cover this very well as they were written when you could only do encryption through custom partitioning, so it says:

"The installer's custom partitioning mode must be capable of the following: ... Creating encrypted partitions"

But the intention is just that install to encrypted partitions should work in general. So now newUI can encrypt without going through custom part, the criteria need updating, and this bug should be covered.

Comment 21 Fedora Update System 2012-11-06 01:37:48 UTC
anaconda-18.25-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/anaconda-18.25-1.fc18

Comment 22 Fedora Update System 2012-11-06 18:49:26 UTC
Package anaconda-18.25-1.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing anaconda-18.25-1.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-17691/anaconda-18.25-1.fc18
then log in and leave karma (feedback).

Comment 23 Fedora Update System 2012-11-07 02:09:46 UTC
anaconda-18.26-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/anaconda-18.26-1.fc18

Comment 24 Adam Williamson 2012-11-07 23:50:27 UTC
Confirmed fixed in 18.26, the dialog pops up right after you reclaim space.

Comment 25 Fedora Update System 2012-11-08 03:23:59 UTC
anaconda-18.27-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/anaconda-18.27-1.fc18

Comment 26 Adam Williamson 2012-11-08 09:14:32 UTC
18.26 went stable. Closing. (Bodhi closing of bugs when updates go stable is currently broken).