Bug 869874

Summary: "node_modules" is detected as a cartridge type when run "service openshift-gears status" on instance
Product: OKD Reporter: Meng Bo <bmeng>
Component: ContainersAssignee: Rob Millner <rmillner>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: low Docs Contact:
Priority: medium    
Version: 2.xCC: mfisher, xtian
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-11-06 18:49:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Meng Bo 2012-10-25 03:41:06 UTC
Description of problem:
Create nodejs app on node, login to instance and run 'service openshift-gears status' to check the app status.
Some error like the following appears:
    Checking http for no1Application 'no1' is running      [  OK  ]
                                                           [  OK  ]
    Checking http for no1runcon: /usr/libexec/openshift/cartridges/node_modules/info/bin/app_ctl.sh: No such file or directory
                                                           [FAILED]
                                                           [FAILED]

Version-Release number of selected component (if applicable):
devenv_2377

How reproducible:
always

Steps to Reproduce:
1.Create nodejs app
2.Login to instance
3.Check gears status
#service openshift-gears status
  
Actual results:
It will try to run some non-exist script. App name is 'no1'.
Checking http for no1runcon: /usr/libexec/openshift/cartridges/node_modules/info/bin/app_ctl.sh: No such file or directory

Expected results:
No such exception.

Additional info:
[root@domU-12-31-38-04-6E-72 ~]# cd /usr/libexec/openshift/cartridges/
[root@domU-12-31-38-04-6E-72 cartridges]# ls
10gen-mms-agent-0.1  abstract-jboss  embedded     jbosseap-6.0  jenkins-client-1.4  mysql-5.1   php-5.3         postgresql-8.4  ruby-1.8
abstract             cron-1.4        haproxy-1.4  jbossews-1.0  metrics-0.1         nodejs-0.6  phpmoadmin-1.0  python-2.6      ruby-1.9
abstract-httpd       diy-0.1         jbossas-7    jenkins-1.4   mongodb-2.2         perl-5.10   phpmyadmin-3.4  rockmongo-1.1   zend-5.6

Comment 1 Rob Millner 2012-10-26 22:28:31 UTC
Added to pull request:
https://github.com/openshift/origin-server/pull/777

Comment 2 Xiaoli Tian 2012-10-29 02:37:46 UTC
(In reply to comment #1)
> Added to pull request:
> https://github.com/openshift/origin-server/pull/777

Move it to ON_QA since above pull request is merged

Comment 3 Meng Bo 2012-10-29 05:31:25 UTC
Tested on devenv_2397, issue has been fixed.

[root@ip-10-122-55-61 ~]# service openshift-gears status
Checking OpenShift Services: 

Checking application no1 status:
-----------------------------------------------
Application 'no1' is running