Bug 870853
Summary: | Review Request: haven - Next Generation Backup System | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Davide Benini <dbenini> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | besser82, dbenini, dbenini, james.hogarth, j, leamas.alec, me, mindruv, package-review, tchollingsworth, turchi, volker27 |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | 768894 | Environment: | |
Last Closed: | 2017-06-05 08:28:48 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 177841 |
Description
Davide Benini
2012-10-29 00:37:06 UTC
*** Bug 768894 has been marked as a duplicate of this bug. *** Have you found a sponsor yet Davide? I've not found a sponsor yet Volker. If you could sponsor me it would be great. Koji scratch build info for the latest Fedora releases: * Fedora 18 http://koji.fedoraproject.org/koji/taskinfo?taskID=5642342 * Fedora 19 http://koji.fedoraproject.org/koji/taskinfo?taskID=5656767 I'll take an informal review. 1. Why not nameing it safehaven but haven? 2. %define _hardened_build 1 should be %global _hardened_build 1 3. Can you ask upstream to avoid using %global _configure ../../configure mkdir -p build/standard build/gtkgui build/full cd build/standard %configure --disable-ext2fs --disable-gmime --without-postgresql? I think this is not cmake, why should we burden ourselves? 4. I think you should add requires of main package for all subpackages. 5. Once you've done the 4, you should remove subpackages' %doc README COPYING As these doc should only present one time in main package. 6. You shouldn't create a new tarball when the download URL is available. rpmlint -i SPECS/haven.spec >SPECS/haven.spec:57: W: configure-without-libdir-spec A configure script is run without specifying the libdir. configure options must be augmented with something like --libdir=%{_libdir} whenever the script supports it. >SPECS/haven.spec: W: invalid-url Source1: haven-icons-0.0.2.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL. >SPECS/haven.spec: W: invalid-url Source0: haven-0.0.2.tar.gz The value should be a valid, public HTTP, HTTPS, or FTP URL. (In reply to Christopher Meng from comment #5) Hi Christopher, > 1. Why not nameing it safehaven but haven? To be aligned with upstream name. > 2. %define _hardened_build 1 I've made the suggested change to the spec file: Spec URL: http://www.dbenini.com/haven/fedora/haven.spec SRPM URL: http://www.dbenini.com/haven/fedora/haven-0.0.2-7.fc19.src.rpm * Koji scratch build info: https://koji.fedoraproject.org/koji/taskinfo?taskID=5776199 > 3. Can you ask upstream to avoid using > > %global _configure ../../configure > mkdir -p build/standard build/gtkgui build/full > cd build/standard > %configure --disable-ext2fs --disable-gmime --without-postgresql? > > I think this is not cmake, why should we burden ourselves? I will get in touch with upstream about this. > 4. I think you should add requires of main package for all subpackages. > > 5. Once you've done the 4, you should remove subpackages' There is no main package, see previous comments. > 6. You shouldn't create a new tarball when the download URL is available. Could you please elaborate this one? Thanks (In reply to Veaceslav Mindru from comment #6) Hi Veaceslav, > rpmlint -i SPECS/haven.spec These seem to be rpmlint false positives. Please check previous comments. Hi, I can see "%doc README COPYING" 3 times. Please only ship one time. I suggest shipping them in main package. And, what does it mean?> --disable-ext2fs --disable-gmime Thanks. Christopher, since each package can be installed separately, as per Fedora Package Licensing Guidelines (https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing): "if a subpackage is independent of any base package (it does not require it, either implicitly or explicitly), it must include copies of any license texts (as present in the source) which are applicable to the files contained within the subpackage." Regarding the flags, they come from upstream. taken ;) ping. Question again, have you found a sponsor yet? Question again, status of this bug? I think we can safely close this request. Davinde, I am a sponsor. If you're still willing to package this please update the bug and let me know. Thank you James, Looks like the "haven" project is no longer maintained, therefore I believe it doesn't make sense to package it anymore. Hi all, I'm the haven author. My original packaging request was really old, so I thought that was practically rejected. I'm very happy to see that there was interest in my work, but in the meantime the original package became obsolete, so I'm waiting to have some spare time to make a new, more modern, version. If you consider that feasible, I can suggest to keep this request frozen but active, so, as soon I have a new version a can come back here to inform you all. Thank you and best whishes, Gabriele Turchi If the project becomes active again and someone steps up to package it in Fedora then a new packaging request can be opened. For the time being, in the interests of janitorial cleanliness, I'll close this for now so it doesn't appear on the "needs reviews, needs sponsors, lists". |