Bug 871882

Summary: missing header: sechash.h in nss 3.14
Product: [Fedora] Fedora Reporter: Jan Horak <jhorak>
Component: nssAssignee: Elio Maldonado Batiz <emaldona>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 18CC: emaldona, kdudka, kengert, stransky
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: nss-3.14-2.fc18 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 927401 (view as bug list) Environment:
Last Closed: 2012-11-27 05:04:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 927401    

Description Jan Horak 2012-10-31 16:00:07 UTC
We can't build xulrunner/firefox for Fedora 18/rawhide right now because compilation fails on:
In file included from /mnt/xulrunner/xulrunner-16.0.2/mozilla-release/security/manager/ssl/src/nsCertOverrideService.cpp:25:0:
../../../../dist/system_wrappers/sechash.h:3:26: fatal error: sechash.h: No such file or directory

Removing this header leads to undeclared HASH_ResultLenByOidTag (no surprise).

Affected packages:
nss-3.14-1.fc18
nss-3.14-4.fc19

Builds are currenly in koji's override (not in updates yet).

Comment 1 Elio Maldonado Batiz 2012-10-31 18:45:47 UTC
Yes, I can confirm this and some innacurate somments on the nss.spec and nss-softokn.spec files indicate I made some incorrect changes in the list of files to install.  My changes were made to take into account some refactoring done upstream for 3.14, were two headers moved in the source tree, and I obviously didn't do it right. I should have it fixed later in the day.

Comment 2 Elio Maldonado Batiz 2012-10-31 19:29:36 UTC
Sharing with you a clearer undertanding of the errors and how to fix them.

These were the moves:
1) mozilla/security/lib/frebl/hasht.h -> mozilla/security/lib/util/hasht.h
2) mozilla/security/lib/softokn/sechash.h -> mozilla/security/lib/pk11wrap/sechash.h

Notice the similarity in the names.

In terms of oir split fedora packaging of nss:
- hasht.h moves from nss-softokn-devel to nss-util-devel and it did.
- sechash.h moves from nss-softokn-devel to nss-devel an it did NOT.

On nss-softokn.spec I no longer install sechash.h which is right as I now nss-util.spec does it. 

The problem is that in nss.spec in the segment commented with
#remove headers shipped nss-softokn-devel and nss-softokn-freebl-devel 
....
rm -f $RPM_BUILD_ROOT/%{_includedir}/nss3/sechash.h

which I should have gotten rid off and I should have added to the install section tagged with %dir %{_includedir}/nss3 teh following line:
%{_includedir}/nss3/sechash.h

This is required for sechash.h to be installed. Enough explanations, now it's time to do it and verify that it actually works.

Comment 3 Fedora Update System 2012-10-31 22:33:33 UTC
nss-3.14-1.fc18, nss-softokn-3.14-1.fc18, nss-util-3.14-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/FEDORA-2012-17351/nss-3.14-1.fc18,nss-softokn-3.14-1.fc18,nss-util-3.14-1.fc18

Comment 4 Elio Maldonado Batiz 2012-10-31 23:12:10 UTC
Correction, sechash.h moved to mozilla/security/nss/lib/cryptohi/sechash.h not to ...pk11erap as I had stated earlier. The point is still that it moved out nss-softokn-devel to nss-devel.

Comment 5 Jan Horak 2012-11-01 15:01:47 UTC
You've probably mixed release number, I've build locally with nss-3.14-2.fc18 (notice release number) and xulrunner build is fine now. The update seems to be for nss-3.14-1.fc18.

Comment 6 Fedora Update System 2012-11-05 22:45:57 UTC
Package nss-softokn-3.14-1.fc18, nss-3.14-5.fc18, nss-util-3.14-1.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing nss-softokn-3.14-1.fc18 nss-3.14-5.fc18 nss-util-3.14-1.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-17351/nss-3.14-5.fc18,nss-softokn-3.14-1.fc18,nss-util-3.14-1.fc18
then log in and leave karma (feedback).

Comment 7 Fedora Update System 2012-11-13 19:06:08 UTC
Package nss-softokn-3.14-1.fc18, nss-util-3.14-1.fc18, nss-3.14-6.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing nss-softokn-3.14-1.fc18 nss-util-3.14-1.fc18 nss-3.14-6.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-17351/nss-3.14-6.fc18,nss-softokn-3.14-1.fc18,nss-util-3.14-1.fc18
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2012-11-21 20:54:04 UTC
Package nss-util-3.14-1.fc18, nss-3.14-7.fc18, nss-softokn-3.14-5.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing nss-util-3.14-1.fc18 nss-3.14-7.fc18 nss-softokn-3.14-5.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-17351/nss-3.14-7.fc18,nss-softokn-3.14-5.fc18,nss-util-3.14-1.fc18
then log in and leave karma (feedback).

Comment 9 Fedora Update System 2012-11-24 03:42:24 UTC
nss-util-3.14-1.fc17,nss-softokn-3.14-5.fc17,nss-3.14-7.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/nss-util-3.14-1.fc17,nss-softokn-3.14-5.fc17,nss-3.14-7.fc17

Comment 10 Fedora Update System 2012-11-27 05:04:03 UTC
nss-util-3.14-1.fc18, nss-3.14-7.fc18, nss-softokn-3.14-5.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2012-12-12 04:33:34 UTC
nss-util-3.14-1.fc17, nss-softokn-3.14-5.fc17, nss-3.14-7.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.