Bug 872424
| Summary: | running pmsuspend on a pmsuspended domain will get unclear error | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | zhpeng |
| Component: | libvirt | Assignee: | Ján Tomko <jtomko> |
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 7.0 | CC: | cwei, dyuan, mprivozn, mzhan, rbalakri, shyu, zhwang |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | libvirt-1.2.14-1.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-11-19 05:36:04 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
This is result of us not checking the state of domain when executing qemuDomainPMSuspendForDuration(). The proper fix is to check it after we obtain job and before we start talking to qemuAgent. Currently, there is no such check and with current implementation we send something like ping to guest agent to tell if it's there or not (this is done with timeout though). And since domain is in s3 state, the guestAgent won't reply, we timeout and report the error about unavailable guest agent. This bug was not selected to be addressed in Red Hat Enterprise Linux 6. We will look at it again within the Red Hat Enterprise Linux 7 product. Upstream patches: https://www.redhat.com/archives/libvir-list/2015-February/msg01219.html commit 723522328f2d92e4c2d5de35b3b3ec0302bb06ac
Author: Ján Tomko <jtomko>
CommitDate: 2015-03-02 08:07:56 +0100
Check if domain is running in qemuDomainAgentIsAvailable
If the domain is not running, the agent will not respond.
Do not even try.
https://bugzilla.redhat.com/show_bug.cgi?id=872424
git describe: v1.2.13-20-g7235223
Verify this bug with libvirt-1.2.15-2.el7.x86_64, Verify steps as following
1.Start a guest agent configured, After guest start successfully, we could see the guest agent stay in "connected" status.
# virsh start 7.0
Domain 7.0 started
# virsh dumpxml 7.0 |grep agent -A3
<source mode='bind' path='/var/lib/libvirt/qemu/channel/target/7.0.org.qemu.guest_agent.0'/>
<target type='virtio' name='org.qemu.guest_agent.0' state='connected'/>
<alias name='channel1'/>
<address type='virtio-serial' controller='0' bus='0' port='1'/>
</channel>
2.Do S3 with the guest, Then the guest agent will run into "disconnected".
# virsh dompmsuspend 7.0 --target mem
Domain 7.0 successfully suspended
# virsh list
Id Name State
----------------------------------------------------
33 7.0 pmsuspended
# virsh dumpxml 7.0 |grep agent -A3
<source mode='bind' path='/var/lib/libvirt/qemu/channel/target/7.0.org.qemu.guest_agent.0'/>
<target type='virtio' name='org.qemu.guest_agent.0' state='disconnected'/>
<alias name='channel1'/>
<address type='virtio-serial' controller='0' bus='0' port='1'/>
</channel>
3.Re-excute S3 or other commands which depends on guest agent, all of them could get expect error
# virsh dompmsuspend 7.0 --target mem
error: Domain 7.0 could not be suspended
error: Guest agent is not responding: QEMU guest agent is not connected
# virsh dompmsuspend 7.0 --target disk
error: Domain 7.0 could not be suspended
error: Guest agent is not responding: QEMU guest agent is not connected
# virsh domtime 7.0
error: Guest agent is not responding: QEMU guest agent is not connected
4.Wakeup the guest, the guest agent's state will come back to "connected" status, also we could scuccessfully excute the virsh commands which depends on guest agent
# virsh dompmwakeup 7.0
Domain 7.0 successfully woken up
# virsh list
Id Name State
----------------------------------------------------
33 7.0 running
# viursh dumpxml 7.0
-bash: viursh: command not found
[root@zhwangrhel71 ~]# virsh dumpxml 7.0 |grep agent -A3
<source mode='bind' path='/var/lib/libvirt/qemu/channel/target/7.0.org.qemu.guest_agent.0'/>
<target type='virtio' name='org.qemu.guest_agent.0' state='connected'/>
<alias name='channel1'/>
<address type='virtio-serial' controller='0' bus='0' port='1'/>
</channel>
# virsh domtime 7.0 --pretty
Time: 2015-05-27 06:01:04
5.Do S4 with guest agent, could excute successfully and get expect error while re-excute it while it finish the first time
# virsh dompmsuspend 7.0 --target disk
Domain 7.0 successfully suspended
# virsh dompmsuspend 7.0 --target disk
error: Domain 7.0 could not be suspended
error: Requested operation is not valid: domain is not running
According to the upper steps, mark this bug verified
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-2202.html |
Description of problem: run pmsuspend guest --target mem/disk twice will get unclear error. Version-Release number of selected component (if applicable): libvirt-0.10.2-6.el6.x86_64 How reproducible: 100% Steps to Reproduce: 1.prepare a guest with qemu-ga ENV 2. # virsh dompmsuspend aaa --target mem Domain aaa successfully suspended # virsh dompmsuspend aaa --target mem error: Domain aaa could not be suspended error: Guest agent is not responding: Guest agent not available for now -----> Should warn something like: error: Domain aaa status is pmsuspended I think guest status should be dompmsuspend after S4 operation. For now it's "shut off": # virsh dompmsuspend aaa --target disk Domain aaa successfully suspended # virsh list --all Id Name State ---------------------------------------------------- - aaa shut off - qcow shut off - rhel63q shut off - win7 shut off # virsh dompmsuspend aaa --target disk ----> run it again, error is not clear either. error: Domain aaa could not be suspended error: Requested operation is not valid: domain is not running Actual results: As steps Expected results: More humanity Additional info: The direct reason of this is "agent not responding" or "guest is donw", But libvirt should check if the guest is in S3/S4 status first, then give a better error msg.