Bug 872694
| Summary: | cinnamon missing dependency for gnome-panel which is requried for the cinnamon-menu-editor | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | jeviolle | ||||||
| Component: | cinnamon | Assignee: | leigh scott <leigh123linux> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 17 | CC: | dan.mashal, leigh123linux, mads | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2012-11-27 05:17:40 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Alacarte and gnome-shell don't have this requirement so why do I need it? https://koji.fedoraproject.org/koji/rpminfo?rpmID=3422408 https://koji.fedoraproject.org/koji/rpminfo?rpmID=3455352 I would argue that if alacarte, gnome-shell, and cinnamon depend on gome-panel to behave as expected then it should be a dependency. Are there plans to make cinnamon not require gnome-panel for menu editing? There will be a groupinstall option for F18 (if they ever release it). yum install @cinnamon-desktop I will consider the issue over the weekend. alacarte _should_ require gnome-panel. So now we have a bug that should be fixed in two places. That is why bundles libraries is a bad idea. Bug 868492. But for now I think it would be bad to make gnome-panel a mandatory dependency from the main cinnamon package. It is only a minor corner that doesn't work. If only it failed in a more civilized way... I suggest moving cinnamon-menu-editor and its dependencies to a subpackage. /usr/share/cinnamon/applets/menu/applet.js should grey out or hide the menu item if the package isn't installed. Created attachment 640476 [details]
Patch #1 to enable/disable menu editor if gnome-panel dep is missing
Created attachment 640477 [details]
Patch #2 to enable/disable menu editor if gnome-panel dep is missing
The patches remove the _Edit Menu_ options if the alacarte gnome-panel dependency isn't present. If it is present it will show the option. If something needs to be changed or added let me know. Hope this helps. cinnamon-1.6.6-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/cinnamon-1.6.6-2.fc18 Package cinnamon-1.6.6-2.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing cinnamon-1.6.6-2.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-18147/cinnamon-1.6.6-2.fc18 then log in and leave karma (feedback). (In reply to comment #7) > Created attachment 640477 [details] > Patch #2 to enable/disable menu editor if gnome-panel dep is missing Thank you for your patches, I did use them in the 1.6.7 build http://pkgs.fedoraproject.org/cgit/cinnamon.git/tree/cinnamon_menu_applet.patch?id=a6ee6e69028b4dcb57786d132e6827096ba690fc Package cinnamon-1.6.6-3.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing cinnamon-1.6.6-3.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-18147/cinnamon-1.6.6-3.fc18 then log in and leave karma (feedback). cinnamon-1.6.7-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/cinnamon-1.6.7-2.fc18 cinnamon-1.6.7-2.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: Unable to edit properties of menu items using the cinnamon-menu-editor: Traceback (most recent call last): File "/usr/share/cinnamon-menu-editor/Alacarte/MainWindow.py", line 441, in on_properties_button_clicked self.on_edit_properties_activate(None) File "/usr/share/cinnamon-menu-editor/Alacarte/MainWindow.py", line 322, in on_edit_properties_activate process = subprocess.Popen(['gnome-desktop-item-edit', file_path], env=os.environ) File "/usr/lib/python2.7/subprocess.py", line 679, in __init__ errread, errwrite) File "/usr/lib/python2.7/subprocess.py", line 1249, in _execute_child raise child_exception OSError: [Errno 2] No such file or directory Version-Release number of selected component (if applicable): cinnamon-1.6.3-1.fc17.i686 How reproducible: Using an non GNOME fedora distribution, such as the XFCE spin this occurs since the gnome-panel dependency isn't install via gnome-desktop. Steps to Reproduce: 1.Install cinnamon without previously having gnome-panel installed. Launch the cinnamon-menu-editor , select and menu item and select properties. Actual results: Traceback (most recent call last): File "/usr/share/cinnamon-menu-editor/Alacarte/MainWindow.py", line 441, in on_properties_button_clicked self.on_edit_properties_activate(None) File "/usr/share/cinnamon-menu-editor/Alacarte/MainWindow.py", line 322, in on_edit_properties_activate process = subprocess.Popen(['gnome-desktop-item-edit', file_path], env=os.environ) File "/usr/lib/python2.7/subprocess.py", line 679, in __init__ errread, errwrite) File "/usr/lib/python2.7/subprocess.py", line 1249, in _execute_child raise child_exception OSError: [Errno 2] No such file or directory Expected results: gnome-desktop-item-edit would open the properties for the menu item Additional info: To resolve install gnome-panel. Suggest adding gnome-panel as a dependency for cinnamon.