Bug 872957
Summary: | Review Request: php-pear-XML-SVG - API for building SVG documents | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||
Component: | Package Review | Assignee: | Shawn Iwinski <shawn> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | nb, notting, package-review, shawn | ||||
Target Milestone: | --- | Flags: | shawn:
fedora-review+
gwync: fedora-cvs+ |
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2012-12-03 03:23:47 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Remi Collet
2012-11-04 16:02:21 UTC
This is an optional dependency of php-horde-Horde-Image * In package.xml, is this cross-project baseinstalldir normal?: <file baseinstalldir="/Horde" md5sum="4c9de300b87bef9f2e967e1b71c1f639" name="docs/examples/basic.php" role="doc" /> <file baseinstalldir="/Horde" md5sum="0ca5fd8f47288120ebeeaa5a1f97daf3" name="docs/examples/radialGradient.php" role="doc" /> The files get installed into the correct PEAR document directory, but it just looks a little strange. * In %prep, you might want to: sed '/README/s/role="data"/role="doc"/' -i package.xml (could also remove "%{pear_datadir}/%{pear_name}" from %files if this is done) * In %files, instead of: %{pear_phpdir}/XML shouldn't it be: %dir %{pear_phpdir}/XML %{pear_phpdir}/XML/SVG (In reply to comment #2) > * In package.xml, is this cross-project baseinstalldir normal?: XML_SVG is a part of the Horde project... (old one, before they have their own channel) > * In %prep, you might want to: > > sed '/README/s/role="data"/role="doc"/' -i package.xml Good catch... I shouldn't have miss it... > %dir %{pear_phpdir}/XML > %{pear_phpdir}/XML/SVG Yes could be more explicit. Changes: https://github.com/remicollet/remirepo/commit/f8416ce3dcfb44d6e9a63859029c6f666879f88e Spec URL: https://raw.github.com/remicollet/remirepo/master/php/pear/php-pear-XML-SVG/php-pear-XML-SVG.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-pear-XML-SVG-1.1.0-2.remi.src.rpm Created attachment 653201 [details]
php-pear-XML-SVG-review.txt
Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-17-x86_64
Command line :/usr/bin/fedora-review -b 872957
=== APPROVED === Thanks for the review New Package SCM Request ======================= Package Name: php-pear-XML-SVG Short Description: API for building SVG documents Owners: remi Branches: f17 f18 el6 el5 InitialCC: Git done (by process-git-requests). php-pear-XML-SVG-1.1.0-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-pear-XML-SVG-1.1.0-2.fc18 php-pear-XML-SVG-1.1.0-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-pear-XML-SVG-1.1.0-2.fc17 php-pear-XML-SVG-1.1.0-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-pear-XML-SVG-1.1.0-2.el6 php-pear-XML-SVG-1.1.0-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/php-pear-XML-SVG-1.1.0-2.el5 php-pear-XML-SVG-1.1.0-2.el6 has been pushed to the Fedora EPEL 6 testing repository. php-pear-XML-SVG-1.1.0-2.fc18 has been pushed to the Fedora 18 stable repository. php-pear-XML-SVG-1.1.0-2.fc17 has been pushed to the Fedora 17 stable repository. php-pear-XML-SVG-1.1.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository. php-pear-XML-SVG-1.1.0-2.el5 has been pushed to the Fedora EPEL 5 stable repository. |