Bug 873226
| Summary: | attaching a dummy interface to bonding device causes a crash | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | sorin <sserban> |
| Component: | kernel | Assignee: | Cong Wang <amwang> |
| Status: | CLOSED ERRATA | QA Contact: | Liang Zheng <lzheng> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 6.3 | CC: | giuseppe, kzhang, lzheng, mmilgram, myakove, nobody, rkhan, tgraf, tlavigne, zhchen |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | kernel-2.6.32-355.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-02-21 06:55:20 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
sorin
2012-11-05 11:43:19 UTC
A guess:
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 3b75d62..34a9db5 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1750,7 +1750,7 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
/*
* Sync the slaves vlan state with the bonds vlan state
*/
- if (slave_dev->ethtool_ops->get_flags &&
+ if (slave_dev->ethtool_ops && slave_dev->ethtool_ops->get_flags &&
slave_dev->ethtool_ops->set_flags) {
orig_flags = slave_dev->ethtool_ops->get_flags(slave_dev);
if (bond_dev->features & NETIF_F_LRO)
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux release for currently deployed products. This request is not yet committed for inclusion in a release. Requesting exception due to regression *** Bug 874578 has been marked as a duplicate of this bug. *** Patch(es) Tested on 2.6.32-355.el6.x86_64 [root@lenovo-thinkstation-01 ~]# uname -r 2.6.32-355.el6.x86_64 [root@lenovo-thinkstation-01 ~]# modprobe dummy [root@lenovo-thinkstation-01 ~]# modprobe bonding 802.1Q VLAN Support v1.8 Ben Greear <greearb> All bugs added by David S. Miller <davem> Ethernet Channel Bonding Driver: v3.6.0 (September 26, 2009) [root@lenovo-thinkstation-01 ~]# ifconfig bond0 up ADDRCONF(NETDEV_UP): bond0: link is not ready 8021q: adding VLAN 0 to HW filter on device bond0 [root@lenovo-thinkstation-01 ~]# ifenslave bond0 dummy0 New slave device dummy0 does not support netpoll Disabling netpoll support for bond0 bonding: bond0: enslaving dummy0 as an active interface with an up link. ADDRCONF(NETDEV_CHANGE): bond0: link becomes ready [root@lenovo-thinkstation-01 ~]# cat /proc/net/bonding/bond0 Ethernet Channel Bonding Driver: v3.6.0 (September 26, 2009) Bonding Mode: load balancing (round-robin) MII Status: up MII Polling Interval (ms): 0 Up Delay (ms): 0 Down Delay (ms): 0 Slave Interface: dummy0 MII Status: up Speed: Unknown Duplex: Unknown Link Failure Count: 0 Permanent HW addr: 1e:7b:67:63:19:10 Slave queue ID: 0 Set VERIFIED Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHSA-2013-0496.html *** Bug 989505 has been marked as a duplicate of this bug. *** |