Bug 873285

Summary:	[RFE] Add support for reverting and deleting of external checkpoints
Product:	Red Hat Enterprise Linux 6	Reporter:	Peter Krempa <pkrempa>
Component:	libvirt	Assignee:	Peter Krempa <pkrempa>
Status:	CLOSED WONTFIX	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	6.4	CC:	acathrow, chhu, cwei, dallan, dyuan, eblake, lsoft-mso-pj, lsu, mzhan, shyu
Target Milestone:	rc	Keywords:	FutureFeature
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:
Clones:	907809 (view as bug list)		Environment:
Last Closed:	2014-04-04 20:59:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	880565, 907809, 1011600

Description Peter Krempa 2012-11-05 13:48:59 UTC

Description of problem:
Users are able to create external checkpoints with libvirt but the implementation of reverting and deleting them is lacking.

Version-Release number of selected component (if applicable):
libvirt-0.10.2-7.el6

Additional info:
Code submitted for review upsteram:
http://www.redhat.com/archives/libvir-list/2012-October/msg01290.html

Comment 3 Eric Blake 2012-11-05 15:03:45 UTC

It is possible (but painful) to manually revert to external checkpoints by use of a series of 'qemu-img', 'virsh edit', and 'virsh restore' commands.  The features proposed in the upstream patch series will make it much easier to do with a single virsh command rather than having to go through a sequence including external, but if it is deemed too late and too risky for 6.4 to pull in the extra code, then we can use the manual procedures as the mitigation.

Comment 5 Huang Wenlong 2012-11-06 07:19:24 UTC

Hi,Peter

I found there is not a bug to trace disk snapshot revert , dose this bug can do that ? or file a new bug to do that ? thanks

Wenlong

Comment 6 Peter Krempa 2012-11-06 08:53:40 UTC

Hi Huang,
please file a new one, this is a feature request.

Comment 7 Peter Krempa 2012-11-06 10:46:28 UTC

*** Bug 873589 has been marked as a duplicate of this bug. ***

Comment 8 Peter Krempa 2012-11-08 10:30:29 UTC

First bit of the functionality committed upstream:

commit 9b5a514b31f0a092cff5402e37d06d1c31f1b992
Author: Peter Krempa <pkrempa>
Date:   Mon Oct 15 17:35:24 2012 +0200

    snapshot: qemu: Add support for external inactive snapshots
    
    This patch adds support for external disk snapshots of inactive domains.
    The snapshot is created by calling using qemu-img by calling:
    
     qemu-img create -f format_of_snapshot -o
     backing_file=/path/to/src,backing_fmt=format_of_backing_image
     /path/to/snapshot
    
    in case the backing image format is known or probing is allowed and
    otherwise:
    
     qemu-img create -f format_of_snapshot -o  backing_file=/path/to/src
     /path/to/snapshot
    
    on each of the disks selected for snapshotting. This patch also modifies
    the snapshot preparing function to support creating external snapshots
    and to sanitize arguments. For now the user isn't able to mix external
    and internal snapshots but this restriction might be lifted in the
    future.

Comment 12 Peter Krempa 2013-11-22 09:21:40 UTC

*** Bug 1033449 has been marked as a duplicate of this bug. ***

Comment 14 RHEL Program Management 2014-04-04 20:59:58 UTC

Development Management has reviewed and declined this request.
You may appeal this decision by reopening this request.

Comment 15 Eric Blake 2014-07-30 13:19:58 UTC

*** Bug 1124854 has been marked as a duplicate of this bug. ***

Comment 16 Red Hat Bugzilla 2023-09-14 01:38:30 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days