Bug 873338

Summary: MAC address shouldn't be freed when performing snapshot preview
Product: Red Hat Enterprise Virtualization Manager Reporter: GenadiC <gcheresh>
Component: ovirt-engineAssignee: Moti Asayag <masayag>
Status: CLOSED CURRENTRELEASE QA Contact: GenadiC <gcheresh>
Severity: high Docs Contact:
Priority: medium    
Version: 3.1.0CC: chetan, danken, dyasny, iheim, lpeer, masayag, mavital, Rhev-m-bugs, sgrinber, yeylon, ykaul
Target Milestone: ---   
Target Release: 3.2.0   
Hardware: x86_64   
OS: Linux   
Whiteboard: network
Fixed In Version: sf13.1 Doc Type: Release Note
Doc Text:
If a virtual machine had a different number of network interfaces in normal mode and in snapshot preview mode, unused MAC addresses in either mode would be released to the pool. This meant that the same MAC address could potentially be assigned to network interfaces belonging to different virtual machines. With this update, a check is performed when a network interface is being plugged to ensure that it is not assigned an already used MAC address.
 Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 948448    

Description GenadiC 2012-11-05 15:25:28 UTC 
Description of problem:

Suppose you have VM with 2 MAC addresses on its 2 NICs (MAC_A and MAC_B) and its Snapshot have only one MAC on its NIC (MAC_A), then performing preview from snapshot will release MAC_B to the pool, so you can assign it to other NICs on other VMs.
As a result you can get a situation where you have 2 VMs with the same MAC address assigned to its NICs


Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Create VM_1 with MAC_A on nic1
2. Create snapshot from VM_1
3. Add to VM_1 MAC_B on nic2
4. Preview VM1 from the snapshot
5. Add MAC_B on one of the NICs of another VM
6. Perform undo for the snapshot of VM_1 from preview mode
  
Actual results:
VM_1 and VM_2 will have MAC_B on its NICs

Expected results:
You are not supposed to have 2 VMs with the same MAC

Additional info:
Comment 2 Moti Asayag 2013-04-04 09:59:22 UTC 
*** Bug 873237 has been marked as a duplicate of this bug. ***
Comment 3 Dan Kenigsberg 2013-04-04 10:33:09 UTC 
If someone plays with teh global allow/disallow flag, and two VMs with duplicate mac addresses exist, we shuld add a similar can-do-action to ensure that only one of these machines is currently running.
Comment 4 GenadiC 2013-04-15 06:23:02 UTC 
Verified on rhevm-3.2.0-10.19.beta2.el6ev.noarch
Comment 5 Itamar Heim 2013-06-11 08:40:56 UTC 
3.2 has been released
Comment 6 Itamar Heim 2013-06-11 08:41:03 UTC 
3.2 has been released
Comment 7 Itamar Heim 2013-06-11 08:41:05 UTC 
3.2 has been released
Comment 8 Itamar Heim 2013-06-11 08:48:28 UTC 
3.2 has been released