Bug 873395

Summary: Review Request: php-horde-Horde-Thrift - Thrift
Product: [Fedora] Fedora Reporter: Remi Collet <fedora>
Component: Package ReviewAssignee: Shawn Iwinski <shawn>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: nb, notting, package-review, shawn
Target Milestone: ---Flags: shawn: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-01-16 17:29:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 873396    
Attachments:
Description Flags
phpci.log
none
php-horde-Horde-Thrift-review.txt none

Description Remi Collet 2012-11-05 18:22:26 UTC 
Spec URL: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Thrift/php-horde-Horde-Thrift.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Thrift-2.0.0-1.remi.src.rpm
Description: Packaged version of the PHP Thrift client

Fedora Account System Username: remi
Comment 1 Remi Collet 2012-12-15 06:28:27 UTC 
Spec URL: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Thrift/php-horde-Horde-Thrift.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Thrift-2.0.1-1.remi.src.rpm
Comment 2 Shawn Iwinski 2012-12-19 18:16:55 UTC 
===== MUST items =====
[!]: Package requires other packages for directories it uses.
[!]: Package must own all directories that it creates.

Since no other Horde packages required, "%dir %{pear_phpdir}/Horde" is missing missing from %files
Comment 3 Remi Collet 2012-12-20 05:40:47 UTC 
Good catch
https://github.com/remicollet/remirepo/commit/e62bfbd62816e73bd35534e2892e997f7d0f8fe5


Spec URL: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Thrift/php-horde-Horde-Thrift.spec
SRPM URL: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Thrift-2.0.1-2.remi.src.rpm
Comment 4 Shawn Iwinski 2012-12-20 16:08:31 UTC 
Created attachment 666753 [details]
phpci.log
Comment 5 Shawn Iwinski 2012-12-20 16:09:03 UTC 
Created attachment 666754 [details]
php-horde-Horde-Thrift-review.txt

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -b 873395 --mock-config fedora-rawhide-x86_64
Comment 6 Shawn Iwinski 2012-12-20 16:09:32 UTC 
No blockers.


===== APPROVED =====
Comment 7 Remi Collet 2012-12-20 16:32:28 UTC 
Thanks for the review

New Package SCM Request
=======================
Package Name: php-horde-Horde-Thrift
Short Description: Thrift
Owners: remi
Branches: f18 el6
InitialCC:
Comment 8 Gwyn Ciesla 2012-12-20 16:40:08 UTC 
Git done (by process-git-requests).
Comment 9 Fedora Update System 2012-12-20 18:47:50 UTC 
php-horde-Horde-Thrift-2.0.1-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/php-horde-Horde-Thrift-2.0.1-2.fc18
Comment 10 Fedora Update System 2012-12-20 18:48:14 UTC 
php-horde-Horde-Thrift-2.0.1-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-horde-Horde-Thrift-2.0.1-2.el6
Comment 11 Fedora Update System 2012-12-21 00:32:58 UTC 
php-horde-Horde-Thrift-2.0.1-2.el6 has been pushed to the Fedora EPEL 6 testing repository.
Comment 12 Fedora Update System 2013-01-16 17:30:00 UTC 
php-horde-Horde-Thrift-2.0.1-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
Comment 13 Fedora Update System 2013-01-16 19:46:38 UTC 
php-horde-Horde-Thrift-2.0.1-2.fc18 has been pushed to the Fedora 18 stable repository.