Bug 874484
| Summary: | xlock exits on segfault, unlocking the screen | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Denys Vlasenko <dvlasenk> | ||||
| Component: | xlockmore | Assignee: | Adrian Reber <adrian> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 16 | CC: | adrian, rhel | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-12-08 04:29:38 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Denys Vlasenko
2012-11-08 10:04:33 UTC
Of course you are right. But this is something you should discuss with upstream and not with me as it sounds more like a rewrite than packaging bug. I cannot help you and will therefore close this bug as CANTFIX. Created attachment 647714 [details]
Make xlock report correct exitcode if it dies from a signal
Reopening. Please accept this simple patch which would allow xlock's parent process to know that it crashed. I compile-tested it: http://koji.fedoraproject.org/koji/taskinfo?taskID=4703546 Before the patch, code was installing signal handlers for SIGSEGV and such, and if SIGSEGV happens, it emits some syslog messages and *exits with exit code 1*. The proper thing to do is to reset signal handlr to SIG_DFL and kill itself. This makes parent see the correct exitcode. Thanks for the patch. I will include it. Have you submitted your patch upstream? (In reply to comment #4) > Thanks for the patch. I will include it. Have you submitted your patch > upstream? Just sent it to xlock-develop.org, with subject: [PATCH] allow xlock's parent to know that it crashed xlockmore-5.41-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/xlockmore-5.41-1.fc18 xlockmore-5.41-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/xlockmore-5.41-1.fc17 xlockmore-5.41-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/xlockmore-5.41-1.fc16 xlockmore-5.41-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/xlockmore-5.41-1.el6 Package xlockmore-5.41-1.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing xlockmore-5.41-1.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-18698/xlockmore-5.41-1.fc18 then log in and leave karma (feedback). xlockmore-5.41-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. xlockmore-5.41-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. xlockmore-5.41-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. xlockmore-5.41-1.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. |