Bug 874720
| Summary: | Review Request: python-anykeystore - A key-value store supporting multiple backends | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralph Bean <rbean> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, package-review |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-11-15 02:41:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Ralph Bean
2012-11-08 17:56:59 UTC
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4668885 I'll go ahead and review this. Look for a full review later today. OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (MIT) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 82ffcd608fea9cfaa903b7731c47a8d36ba346bf49cf98f8dabee83083d08412 anykeystore-0.2.tar.gz 82ffcd608fea9cfaa903b7731c47a8d36ba346bf49cf98f8dabee83083d08412 anykeystore-0.2.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have subpackages require base package with fully versioned depend. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. rpmlint says: python-anykeystore.noarch: E: zero-length /usr/share/doc/python-anykeystore-0.2/CHANGES.txt python-anykeystore.src: W: spelling-error Summary(en_US) backends -> back ends, back-ends, backhands python-anykeystore.src: W: spelling-error %description -l en_US backends -> back ends, back-ends, backhands Might drop CHANGES.txt since it's 0 len? I don't see any blockers here, so this package is APPROVED. New Package SCM Request ======================= Package Name: python-anykeystore Short Description: A key-value store supporting multiple backends Owners: ralph Branches: f17 f18 el6 InitialCC: Git done (by process-git-requests). python-anykeystore-0.2-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-anykeystore-0.2-3.el6 python-anykeystore-0.2-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-anykeystore-0.2-2.fc17 python-anykeystore-0.2-2.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-anykeystore-0.2-2.fc18 python-anykeystore-0.2-3.el6 has been pushed to the Fedora EPEL 6 testing repository. python-anykeystore-0.2-3.el6 has been pushed to the Fedora EPEL 6 stable repository. python-anykeystore-0.2-2.fc17 has been pushed to the Fedora 17 stable repository. python-anykeystore-0.2-2.fc18 has been pushed to the Fedora 18 stable repository. Package Change Request ====================== Package Name: python-anykeystore New Branches: epel7 Owners: ralph Git done (by process-git-requests). |