Bug 875316
| Summary: | Review Request: python-praw - A python package that allows for simple access to reddit's API | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Elad Alfassa <elad> |
| Component: | Package Review | Assignee: | Minh Ngo <nlminhtl> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | nlminhtl, notting, package-review |
| Target Milestone: | --- | Flags: | nlminhtl:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-11-23 03:12:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Elad Alfassa
2012-11-10 12:43:23 UTC
Please specify a version of the GPL license. Divide your description into lines. [ignotus@laptop fedora]$ rpmlint praw-1.0.15-1.fc18.src.rpm praw.src: W: spelling-error Summary(en_US) reddit's -> credit's, edit's praw.src: W: spelling-error %description -l en_US reddit's -> credit's, edit's praw.src: E: description-line-too-long C PRAW, an acronym for "Python Reddit API Wrapper", is a python package that allows for simple access to reddit's API. PRAW aims to be as easy to use as possible praw.src: W: invalid-license GPL 1 packages and 0 specfiles checked; 1 errors, 3 warnings. Fixed. Spec URL: http://elad.fedorapeople.org/reviews/praw/praw.spec SRPM URL: http://elad.fedorapeople.org/reviews/praw/praw-1.0.15-2.fc18.src.rpm Looks like a library to work with reddit API, so you must rename it to python-praw according to the packaging naming guidelines http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29 From the README.md file
>Installation via `pip` or `easy_install` automatically installs PRAW's only
>dependency, the module [six](http://pypi.python.org/pypi/six/). If you install
>via `setup.py` you'll need to install `six` manually.
So please add python-six to dependencies
There are some documentations in the docs directory of the source file. Please add it into the python-praw-doc package. For generating a documentation you need a python-sphinx package. (In reply to comment #5) > There are some documentations in the docs directory of the source file. > Please add it into the python-praw-doc package. > > For generating a documentation you need a python-sphinx package. tried generating them locally, it results in empty documentation template page, so I won't include the docs in the package. All other issues fixed: Spec URL: http://elad.fedorapeople.org/reviews/praw/python-praw.spec SRPM URL: http://elad.fedorapeople.org/reviews/praw/python-praw-1.0.15-3.fc18.src.rpm Seems supports also python3 (https://github.com/praw-dev/praw/pull/70). So you can make also a package python3-praw for python3. Look here for example ( http://pkgs.fedoraproject.org/cgit/python-six.git/tree/python-six.spec ). I can do that later, I don't think it's a reason to block the review request. I said you can, not you must :). APPROVED New Package SCM Request ======================= Package Name: python-praw Short Description: A python package that allows for simple access to reddit's API Owners: elad Branches: f17 f18 InitialCC: Git done (by process-git-requests). python-praw-1.0.15-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-praw-1.0.15-3.fc18 python-praw-1.0.15-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/python-praw-1.0.15-3.fc17 python-praw-1.0.15-3.fc18 has been pushed to the Fedora 18 testing repository. python-praw-1.0.15-3.fc17 has been pushed to the Fedora 17 stable repository. python-praw-1.0.15-3.fc18 has been pushed to the Fedora 18 stable repository. |