Bug 875352

Needed by mfiler4 (bug 875353)

http://mtasaka.fedorapeople.org/Review_request/mfiler4-related/xyzsh.spec
http://mtasaka.fedorapeople.org/Review_request/mfiler4-related/xyzsh-1.2.0-1.fc.src.rpm

* Wed Nov 14 2012 Mamoru TASAKA <mtasaka> - 1.2.0-1
- 1.2.0

http://mtasaka.fedorapeople.org/Review_request/mfiler4-related/xyzsh.spec
http://mtasaka.fedorapeople.org/Review_request/mfiler4-related/xyzsh-1.2.5-1.fc.src.rpm

* Sun Dec  9 2012 Mamoru TASAKA <mtasaka> - 1.2.5-1
- 1.2.5

http://mtasaka.fedorapeople.org/Review_request/mfiler4-related/xyzsh.spec
http://mtasaka.fedorapeople.org/Review_request/mfiler4-related/xyzsh-1.2.7-1.fc.src.rpm

* Wed Jan  2 2013 Mamoru TASAKA <mtasaka> - 1.2.7-1
- 1.2.7

Package Review
==============

Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated



===== MUST items =====

C/C++:
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package contains no bundled libraries.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Sources contain only permissible code or content.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[?]: Package uses nothing in %doc for runtime.
[-]: Package is not known to require ExcludeArch.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Package complies to the Packaging Guidelines
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package consistently uses macro (instead of hard-coded directory
     names).
[x]: Package is named using only allowed ASCII characters.
[x]: Package is named according to the Package Naming Guidelines.
[x]: No %config files under /usr.
[x]: Package does not generate any conflict.
     Note: Package contains no Conflicts: tag(s)
[x]: Package do not use a name that already exist
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package installs properly.
[x]: Package is not relocatable.
[-]: Requires correct, justified where necessary.
[x]: CheckResultdir
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file is legible and written in American English.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Large documentation must go in a -doc subpackage.
     Note: Documentation size is 92160 bytes in 7 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[x]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[x]: The placement of pkgconfig(.pc) files are correct.
[-]: Scriptlets must be sane, if used.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX / PatchY prefixed with %{name}.
[x]: SourceX is a working URL.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.


Rpmlint
-------
Checking: xyzsh-devel-1.2.7-1.fc17.x86_64.rpm
          xyzsh-1.2.7-1.fc17.x86_64.rpm
          xyzsh-debuginfo-1.2.7-1.fc17.x86_64.rpm
          xyzsh-1.2.7-1.fc17.src.rpm
xyzsh-devel.x86_64: W: spelling-error Summary(en_US) cmigemo -> hegemonic
xyzsh-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 2 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint xyzsh xyzsh-devel xyzsh-debuginfo
xyzsh-devel.x86_64: W: spelling-error Summary(en_US) cmigemo -> hegemonic
xyzsh-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 2 warnings.
# echo 'rpmlint-done:'

I have a little cosmetic annoyance as you seems to prefer tab over space, it looks weird to have a tab for the %doc line instead of one simple space.
Also the Group line of the devel is missing one tab.

Another concern is about dynamic patching. Specially as if the SONAME is  correctly set in the shared object, your patch might become wrong.

Besides that I have not other concern, usability was tested by building mfiler4


--------------------------------------

This package (xyzsh) is APPROVED by me

--------------------------------------

Thank you for review!

New Package SCM Request
=======================
Package Name: xyzsh
Short Description: Interactive shell and text processing tool
Owners: mtasaka
Branches: f17 f18
InitialCC:

Git done (by process-git-requests).

Rebuilt on F-19/18/17, push requested on F-18/F-17 (on bodhi).
F-19 build should appear on koji buildroot soon.

Thank you for review and git procedure, closing.