Bug 875669

Summary: 'kernel' referenced before assignment
Product: [Fedora] Fedora Reporter: Jan Sedlák <jsedlak>
Component: fedupAssignee: Will Woods <wwoods>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 18CC: tflink, wwoods
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-11-13 15:09:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
fedup log none

Description Jan Sedlák 2012-11-12 10:47:34 UTC 
Description of problem:
When I tried fedup-cli tool, it failed with "kernel referenced before assignment". It was in fedup-cli on line 247 - there is "prep_boot" called, but since I have used --skip-kernel argument, variable 'kernel' doesnt' exists.

How reproducible:
Always.

Steps to Reproduce:
1. Try to upgrade fedora with "fedup-cli --network 18 --skipkernel"
  
Actual results:
It fails with python traceback.

Expected results:
It shouldn't.
Comment 1 Tim Flink 2012-11-12 16:17:22 UTC 
How did you install fedup?

Can you attach the traceback you saw?
Comment 2 Jan Sedlák 2012-11-13 10:38:59 UTC 
I have cloned it using git from github, installed python-devel, did "make install". Traceback:

setting up system for upgrade
Traceback (most recent call last):
  File "/bin/fedup-cli", line 271, in <module>
    main(args)
  File "/bin/fedup-cli", line 243, in main
    prep_boot(kernel, initrd)
UnboundLocalError: local variable 'kernel' referenced before assignment
Comment 3 Jan Sedlák 2012-11-13 13:09:52 UTC 
I was using --skipkernel argument, as stated in readme on github.
Comment 4 Jan Sedlák 2012-11-13 13:27:38 UTC 
Created attachment 644099 [details]
fedup log
Comment 5 Will Woods 2012-11-13 15:09:25 UTC 
Should be fixed in commit 0e72580.

As a side note, I'd prefer if people used github for issues that are only found in code direct from the git repo.