Bug 875729
Summary: | add possibility to autoconfigure and set tls-port only | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 6 | Reporter: | David Jaša <djasa> |
Component: | libvirt | Assignee: | Peter Krempa <pkrempa> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Virtualization Bugs <virt-bugs> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | 6.4 | CC: | acathrow, cwei, dallan, dyuan, mkletzan, mzhan, pkrempa, weizhan |
Target Milestone: | rc | Keywords: | Upstream |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-12-05 23:33:15 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
David Jaša
2012-11-12 13:39:50 UTC
This should be possible with autoport='no' and tlsPort='-1' for a while now (sorry, can't find the right upstream commit). This was dealt with in Bug #913244. If that solves the issue, I believe this BZ can be CLOSED as DUP of that bug. Could you please confirm your issue is solved in latest package? No, it does not in libvirt 0.10 / RHEL 6.4: # rpm -q libvirt libvirt-0.10.2-18.el6.x86_64 # cat tls-only.xml <?xml version="1.0"?> <domain type="kvm" xmlns:qemu="http://libvirt.org/schemas/domain/qemu/1.0"> <name>tls-only</name> <memory>32768</memory> <os> <type arch="x86_64" machine="pc">hvm</type> </os> <devices> <graphics type="spice" autoport="no" tlsPort="-1" passwd="123" > <listen type="address" address="::" /> </graphics> <video> <model type="qxl" vram="32768" heads="1"/> </video> </devices> </domain> # virsh domxml-to-native qemu-argv tls-only.xml LC_ALL=C PATH=/sbin:/usr/sbin:/bin:/usr/bin QEMU_AUDIO_DRV=spice /usr/libexec/qemu-kvm -name tls-only -S -M pc -enable-kvm -m 32 -smp 1,sockets=1,cores=1,threads=1 -uuid d2423437-abe7-52e7-c768-741920bd13a3 -nodefconfig -nodefaults -chardev socket,id=charmonitor,path=/var/lib/libvirt/qemu/tls-only.monitor,server,nowait -mon chardev=charmonitor,id=monitor,mode=control -rtc base=utc -no-shutdown -no-acpi -device piix3-usb-uhci,id=usb -spice port=0,addr=::,x509-dir=/etc/pki/libvirt-spice,seamless-migration=on -vga qxl -global qxl-vga.vram_size=33554432 -device virtio-balloon-pci,id=balloon0 Please try version >=libvirt-0.10.2-18.el6_4.1 where this should have been fixed. I tried and the behaviour is the same, port=0 is still given to the CLI. Specifying "port=0" has the same meaning for qemu as not specifying the port at all. The "tls-port=", however, should be specified and allocated automatically. Could you post your output of the command: virsh domxml-to-native qemu-argv tls-only.xml With the libvirt version from comment #4? Thanks (In reply to comment #6) > Specifying "port=0" has the same meaning for qemu as not specifying the port > at all. I know that qemu behaves that way but is it documented somewhere? I didn't see it and I've read some concerns that the very presence of port=0 would mean auto-allocation of a port... > The "tls-port=", however, should be specified and allocated > automatically. Could you post your output of the command: > > virsh domxml-to-native qemu-argv tls-only.xml > > With the libvirt version from comment #4? Thanks Exactly the same as in #c3: LC_ALL=C PATH=/sbin:/usr/sbin:/bin:/usr/bin QEMU_AUDIO_DRV=spice /usr/libexec/qemu-kvm -name tls-only -S -M pc -enable-kvm -m 32 -smp 1,sockets=1,cores=1,threads=1 -uuid 0b855b8d-c8d1-88b9-5414-525cbe771cc2 -nodefconfig -nodefaults -chardev socket,id=charmonitor,path=/var/lib/libvirt/qemu/tls-only.monitor,server,nowait -mon chardev=charmonitor,id=monitor,mode=control -rtc base=utc -no-shutdown -no-acpi -device piix3-usb-uhci,id=usb -spice port=0,addr=::,disable-ticketing,seamless-migration=on -vga qxl -global qxl-vga.ram_size=67108864 -global qxl-vga.vram_size=33554432 -device virtio-balloon-pci,id=balloon0 I believe that the patches that were meant to fix https://bugzilla.redhat.com/show_bug.cgi?id=953126 are solving this issue too. I'm reassigning this to me and I'll verify that it's the case. The code generating the qemu commandline when a machine is run under libvirt's control was indeed fixed by patches for bug 953126. commit 246d0068ac34d1937ecffa91e59db3288607f552 Author: Peter Krempa <pkrempa> Date: Mon Apr 29 14:12:59 2013 +0200 qemu: Do fake auto-allocation of ports when generating native command When attempting to generate the native command line from an XML file that uses graphics port auto allocation, the generated commandline wouldn't be valid. This patch adds fake autoallocation of ports as done when starting the actual machine. fixes the output of domxml-to-native virsh command and the underlying API that was used in reproducer examples in this bugreport. The domxml-to-native returns fake port numbers if auto allocation is requested as libvirt can't be responsible for processes run out of it's control. v1.0.5-36-g246d006 This bug is fixed in RHEL 6.5/libvirt-0.10.2-29.el6.x86_64 |