Bug 875856

Summary:	Review Request: ip-info - read/flash IP address info on a system with no monitor
Product:	[Fedora] Fedora	Reporter:	Chris Tyler <ctyler.fedora>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED INSUFFICIENT_DATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	anto.trande, msuchy, package-review, ppisar
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-08-21 09:23:39 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Chris Tyler 2012-11-12 17:07:21 UTC

Spec URL: http://england.proximity.on.ca/chris/package-review/ip-info/ip-info.spec
SRPM URL: http://england.proximity.on.ca/chris/package-review/ip-info/ip-info-0.1-3.fc16.src.rpm
Description: 
ip-info is a simple software package for determining IP address
information without using a video monitor. The IP address can be
displayed as flashes on the system LED or read over the system
speakers using espeak.

Fedora Account System Username: ctyler

Comment 1 Chris Tyler 2012-11-12 17:23:03 UTC

Additional info:

- This package is targeted at systems such as the Raspberry Pi and Pandaboard, which may or may not have a monitor attached

- This package successfully builds on Koji (scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=4679675)

- rpmlint output:

$ rpmlint ip-info.spec ip-info-0.1-3.fc16.src.rpm ip-info-0.1-3.fc16.noarch.rpm
ip-info.src: W: spelling-error %description -l en_US espeak -> speak, bespeak, e speak
2 packages and 1 specfiles checked; 0 errors, 1 warnings.

Comment 2 Petr Pisar 2012-11-13 09:12:08 UTC

Could you sub-package the ip-read tool not to force people to install espeak and all the audio subsystem if they do not have audio hardware?

Comment 3 Petr Pisar 2012-11-13 09:28:37 UTC

The systemd unit files have to be (de-)configured properly <https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd>.

Also you should run-require: sed, grep, coreutils, and net-tools for tools you call from the bash scripts.

Comment 4 Petr Pisar 2012-11-13 10:16:19 UTC

One functional issue: If the default-on trigger is compiled as module and not loaded, then it's not available. It would be good to check `default-on' is listed in the trigger at the beginning. Maybe the unit file could try to load the module (or what's the correct way how to load modules with systemd).

Comment 5 Chris Tyler 2013-03-26 15:17:28 UTC

Updated package.

Spec URL: http://england.proximity.on.ca/chris/package-review/ip-info/0.2-1/ip-info.spec
SRPM URL: http://england.proximity.on.ca/chris/package-review/ip-info/0.2-1/ip-info-0.2-1.fc18.src.rpm

Changes:
- systemd scriptlets added
- updated scripts to use 'ip addr' instead of 'ifconfig' on F18+
- fixed up dependencies

Comment 6 Antonio T. (sagitter) 2013-10-20 12:19:31 UTC

(In reply to Chris Tyler from comment #5)
> Updated package.
> 
> Spec URL:
> http://england.proximity.on.ca/chris/package-review/ip-info/0.2-1/ip-info.
> spec
> SRPM URL:
> http://england.proximity.on.ca/chris/package-review/ip-info/0.2-1/ip-info-0.
> 2-1.fc18.src.rpm

Hi Chris.

Source0 link is uncomplete, its extension (tar.gz) is missing. 
Please, remove %defattr(-,root,root,-).

Comment 7 Miroslav Suchý 2015-08-21 09:23:39 UTC

No response for years. Closing. Feel free to reopen if you want to continue.