Bug 87588
| Summary: | redhat-config-xfree uses ' 17" COLOR' as monitor name | ||
|---|---|---|---|
| Product: | [Retired] Red Hat Linux | Reporter: | Gerald Teschl <gt> |
| Component: | rhpl | Assignee: | Brent Fox <bfox> |
| Status: | CLOSED RAWHIDE | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 8.0 | CC: | mharris |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.98.1-2 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2003-04-24 20:57:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
I can't find that string in our monitor database anywhere. See for yourself in the /usr/share/hwdata/MonitorsDB file. OK. But how did it get there? Could it be that the monitor returned this string when probed? Quite possibly. As root, run '/usr/sbin/ddcprobe' and see if the string is returned by ddcprobe. As I already suspected: Monitor DDC probe results ID: STC1712 Name: 17" COLOR Horizontal Sync (kHZ): 30-95 Vertical Sync (HZ) : 50-160 Width (mm): 320 Height(mm): 240 Always sanitize strings before you use them;-) This monitor ID isn't in our monitors database. This name '17" COLOR' is being returned from the monitor hardware itself, so there's not much I can do about that. However, if you'll tell me exactly what kind of monitor this is, I'll try to add it to our database with a more meaningful name. I am afraid I don't quite get it: Of course there is nothing you can do about the name. But I feel you should not use the name returned by the probe as is. Just remove all characters other than say letters, numbers, space from the string returned by the probe before putting it into the config file. There is no way one can predict what weird strings some crappy hardware might return... In the above case it will say "17 COLOR" in the config file, which does not make to much sense, but it is better than a syntax error. The monitor is what it claims to be, a 17" color monitor. The returned frequencies are ok. I don't know the brand and I can't find out right now, since I am in a different building. If you provide me with the monitor information, I will add it to the MonitorsDB. Once the data is in there, the program will use the name it finds in the database instead of what is returned from the monitor. This will avoid the syntax error. This is a noname monitor: On the monitor it just says "Platin". On the pack it says "B-712UDT" for the model and "SPTI" for the manufacturer. However, I still feel it is better to strip any non sane character from the string before putting it into XF86COnfig as a precaution, since other monitors might return similar strings. Ok, I've changed monitor.py in rhpl to strip '"' chars from probed monitor strings. It should be fixed in rhpl-0.98.1-2. |
I just tried to reconfigure x after replacing the vga card, which failed. The Xserver complained about syntax errors in the monitor section and inspection of the config file revealed the cause: ModelName " 17" COLOR" Indedd, '17" COLOR' is not a good choice for a monitor name;-) Please grep your database for 17" and fix this.