Bug 876404
| Summary: | Review Request: php-channel-aws - Adds the Amazon Web Services channel to PEAR | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Joseph Marrero <jmarrero> | ||||
| Component: | Package Review | Assignee: | Gregor Tätzner <gregor> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | fedora, gregor, jmarrero, notting, package-review | ||||
| Target Milestone: | --- | Flags: | gregor:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2013-03-12 08:48:05 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Joseph Marrero
2012-11-14 02:53:06 UTC
successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4686415 Created attachment 645398 [details]
pre-review
minor issues:
php-channel-aws.src:60: W: macro-in-%changelog %clean
php-channel-aws.src:41: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 41)
I think the version should start with 1.0 since this is the initial package for aws channel. Well, at least that looks less arbitrary than 1.3. Make also sure to adjust the version strings in the changelog (note that this is nothing you would ever do in an already imported package :) )
@Gregor: version have no sense for channel packages, but we are used to take the REST version provided (from the channel.xml). So, as this channel provides REST1.3, I think 1.3 is right. But of course, there is no Guildelines, so this is a packager choice. old packages in: http://marreroj.com/fedora/review-packages/old/* Spec URL: http://marreroj.com/fedora/review-packages/php-channel-aws.spec SRPM URL: http://marreroj.com/fedora/review-packages/php-channel-aws-1.3-3.fc18.src.rpm I agree with Remi on the version numbers thingy. fixed the two rpmlint issues. we're good to go then
LICENSE: OK
BUILD & INSTALL: OK
Rpmlint
-------
Checking: php-channel-aws-1.3-3.fc19.noarch.rpm
php-channel-aws-1.3-3.fc19.src.rpm
php-channel-aws.noarch: W: no-documentation
php-channel-aws.src:19: W: unversioned-explicit-provides php-channel(%{channelname})
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
MD5-sum check
-------------
http://pear.amazonwebservices.com/channel.xml :
CHECKSUM(SHA256) this package : 7fe130dd50bbfcce6fb15df93eb2b22fe235e06b590b8a2067ebc688ec6daa16
CHECKSUM(SHA256) upstream package : 7fe130dd50bbfcce6fb15df93eb2b22fe235e06b590b8a2067ebc688ec6daa16
APPROVED
========
New Package SCM Request ======================= Package Name: php-channel-aws Short Description: Adds the Amazon Web Services channel to PEAR Owners: jmarrero Branches: f17 f18 el6 InitialCC: Git done (by process-git-requests). php-channel-aws-1.3-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-channel-aws-1.3-3.fc18 php-channel-aws-1.3-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-channel-aws-1.3-3.fc17 php-channel-aws-1.3-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-channel-aws-1.3-3.el6 php-channel-aws-1.3-3.fc18 has been pushed to the Fedora 18 testing repository. php-channel-aws-1.3-3.fc17 has been pushed to the Fedora 17 stable repository. php-channel-aws-1.3-3.fc18 has been pushed to the Fedora 18 stable repository. php-channel-aws-1.3-3.el6 has been pushed to the Fedora EPEL 6 stable repository. |