Bug 876408

Spec URL: https://github.com/hroncok/SPECS/raw/master/perl-Boost-Geometry-Utils.spec
SRPM URL: https://github.com/downloads/hroncok/SPECS/perl-Boost-Geometry-Utils-0.05-4.fc18.src.rpm

- Using dos2unix instead of sed
- Removed deleting empty dirs
- Dropped perl macro
- Removed BRs provided by perl package

I'll take the review...

> - Using dos2unix instead of sed

Why?  What's the advantage?

The action is more obvious (readable) in the spec, I suppose.

When reading the spec over again, some part of my brain remembered, someone has told me once to use dos2unix instead of sed. It's part of my subconscious now.

(In reply to comment #3)
> The action is more obvious (readable) in the spec, I suppose.
> 
> When reading the spec over again, some part of my brain remembered, someone
> has told me once to use dos2unix instead of sed. It's part of my
> subconscious now.

It's mostly a matter of style.  I was just curious.

Issues found while looking at your package:

Missing build-time dependencies:
perl(File::Temp) (from t/00-compile.t:11)
perl(Exporter) (from lib/Boost/Geometry/Utils.pm:9)
perl(XSLoader) (from lib/Boost/Geometry/Utils.pm:12)

You can drop the following deps as they aren't actually used anywhere:
perl(ExtUtils::Typemaps::Default)
perl(ExtUtils::XSpp)
perl(Module::Build)

What's the point of including the 'src' directory in the documentation?
If you really want to package it, consider putting it in a doc subpackage.  My guess is the package users probably won't need those 31MiB installed.  The same applies to the xsp directory, even though it's quite small.
If you're going to keep these, also change the License tag to "(GPL+ or Artistic) and Boost and MIT".

And...
(In reply to comment #1)
> - Dropped perl macro
You could also drop it in the MODULE_COMPAT virtual dependency line.

Spec URL: https://github.com/hroncok/SPECS/raw/master/perl-Boost-Geometry-Utils.spec
SRPM URL: https://github.com/downloads/hroncok/SPECS/perl-Boost-Geometry-Utils-0.05-5.fc18.src.rpm

- Dropped perl macro in MODULE_COMPAT
- Removed src and xsp from %%doc
- Dropped converting src to UTF-8
- Dropped converting newlines and dos2unix BR
- Dropped BRs: perl(ExtUtils::Typemaps::Default)
               perl(ExtUtils::XSpp)
               perl(Module::Build)
- Added BRs:   perl(File::Temp)
               perl(Exporter)
               perl(XSLoader)

Everything addressed.

However, the build fails because it can't find the prerequisities specified in Build.PL.  I'm sorry for the confusion -- I should have checked that.  Please, re-add the dropped BRs before pushing the package.

Anyway, approving.

Spec URL: https://github.com/hroncok/SPECS/raw/master/perl-Boost-Geometry-Utils.spec
SRPM URL: https://github.com/downloads/hroncok/SPECS/perl-Boost-Geometry-Utils-0.05-6.fc18.src.rpm

Added back perl(ExtUtils::Typemaps::Default), builds in mock.

New Package SCM Request
=======================
Package Name: perl-Boost-Geometry-Utils
Short Description: Boost::Geometry::Utils Perl module
Owners: churchyard
Branches: f17 f18
InitialCC: perl-sig

Git done (by process-git-requests).

perl-Boost-Geometry-Utils-0.05-6.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/perl-Boost-Geometry-Utils-0.05-6.fc18

perl-Boost-Geometry-Utils-0.05-6.fc18 has been pushed to the Fedora 18 testing repository.

perl-Boost-Geometry-Utils-0.05-6.fc18 has been pushed to the Fedora 18 stable repository.

perl-Boost-Geometry-Utils-0.05-6.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/perl-Boost-Geometry-Utils-0.05-6.fc17

perl-Boost-Geometry-Utils-0.05-6.fc17 has been pushed to the Fedora 17 stable repository.