Bug 876939

Summary:	Return "FAILED" if trying to stop openshift-port-proxy which is already stopped
Product:	OpenShift Container Platform	Reporter:	Xiaoli Tian <xtian>
Component:	Node	Assignee:	Brenton Leanhardt <bleanhar>
Status:	CLOSED ERRATA	QA Contact:	libra bugs <libra-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	1.2.0	CC:	bleanhar, jkeck, xjia
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-01-31 20:32:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Xiaoli Tian 2012-11-15 10:42:01 UTC

Description of problem:
It will fail if trying to stop openshift-port-proxy which is already stopped:
[root@broker graphviz]# service openshift-port-proxy status
haproxy is stopped
[root@broker graphviz]# service openshift-port-proxy stop
Stopping openshift-port-proxy:                             [FAILED]

Version-Release number of selected component (if applicable):
openshift-origin-port-proxy-1.0.1-1.el6op.noarch

How reproducible:
Always

Steps to Reproduce:
1.service openshift-port-proxy stop
2.service openshift-port-proxy status
3.service openshift-port-proxy stop
  
Actual results:
It failed in step 3

Expected results:
It should return success even if it stops an stopped service

Additional info:

Comment 1 John Keck 2012-11-15 15:45:13 UTC

Definitely need to fix this, but not needed for GA.  Will release either in 1.1 or errata filing.

Comment 3 Brenton Leanhardt 2012-12-07 17:58:53 UTC

Upstream: https://github.com/openshift/origin-server/pull/1041

This should make it into the next puddle.

Comment 4 xjia 2012-12-11 05:05:53 UTC

Verify:
[root@node ~]# service openshift-port-proxy status
haproxy is stopped
[root@node ~]# service openshift-port-proxy stop
Stopping openshift-port-proxy: (already stopped)           [  OK  ]

Version:
OSE 1.1.x 2012-12-10.1

Comment 6 errata-xmlrpc 2013-01-31 20:32:53 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0220.html