Bug 877188

Summary: Luci lets users set max_restarts/max_failures without setting the corresponding timeout
Product: Red Hat Enterprise Linux 6 Reporter: Ryan McCabe <rmccabe>
Component: luciAssignee: Ryan McCabe <rmccabe>
Status: CLOSED ERRATA QA Contact: Cluster QE <mspqa-list>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 6.3CC: cluster-maint, rsteiger
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: luci-0.26.0-29.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-02-21 08:22:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 886216    

Description Ryan McCabe 2012-11-15 22:13:51 UTC
luci will allow users to set max_restarts, __max_restarts, and __max_failures without setting their corresponding timeouts, and vice versa.

A fix for these issues is already upstream:

commit 616e70d2a760175bd27262766efb85e63ea980fd
Author: Ryan McCabe <rmccabe>
Date:   Thu Nov 15 11:08:48 2012 -0500

    luci: Fix handling of subtree options
    
    For subtrees, error out if __max_failures is set by __failure_expire_time
    is not, and vice versa. Also error out if __max_restarts is set but
    __restart_expire_time is not, and vice versa.
    
    Signed-off-by: Ryan McCabe <rmccabe>

commit 0f0db639ab786c386fb8182fa82ce6bbe93dda8e
Author: Ryan McCabe <rmccabe>
Date:   Thu Nov 15 10:56:52 2012 -0500

    luci: Error out if max_restarts is set but not restart_expire_time
    
    Error out if max_restarts is set but restart_expire_time is not set,
    and vice versa, on the service group config form.
    
    Signed-off-by: Ryan McCabe <rmccabe>

Comment 7 errata-xmlrpc 2013-02-21 08:22:51 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-0309.html