Bug 878367

Summary:	iscsid.conf contains wrong iscsid.startup invocation
Product:	[Fedora] Fedora	Reporter:	Tomasz Torcz <tomek>
Component:	iscsi-initiator-utils	Assignee:	Chris Leech <cleech>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	18	CC:	agrover, cleech, hdegoede, johannbg
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-02-05 13:09:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tomasz Torcz 2012-11-20 10:00:15 UTC

Description of problem:
"iscsiadm" runs SYSV script for "iscsid" directly. It causes several problems:

1) it will stop work when sysv script is finally dropped in favor of proper unit files

2) as iscsiadm is often run by administrator, iscsid init script is tied to particular root session, so
  - it will inherit root's environment, which is wrong and can cause unexpected results
  - iscsid will be killed when root logs out

3) when libvirtd invokes iscsiadm, the resulting iscsid daemon will be part of libvirtd cgroup, so proper supervising will not happen

Version-Release number of selected component (if applicable):
iscsi-initiator-utils-6.2.0.872-19.fc18.x86_64

Steps to Reproduce:
1. kill iscsid
2. invoke iscsiadm
3. notice iscsid was started.
  

Additional info:
After this long writing, actual fix is trivial. It will work with both sysv script and systemd unit file:


--- iscsid.conf.orig	2012-11-20 10:50:01.578919503 +0100
+++ iscsid.conf	2012-11-20 10:50:12.082769600 +0100
@@ -17,7 +17,7 @@
 # maintainers.
 #
 # Default for Fedora and RHEL. (uncomment to activate).
-iscsid.startup = /etc/rc.d/init.d/iscsid force-start
+iscsid.startup = /usr/bin/systemctl start iscsid.service
 # 
 # Default for upstream open-iscsi scripts (uncomment to activate).
 # iscsid.startup = /sbin/iscsid

Comment 1 Tomasz Torcz 2013-11-18 17:19:48 UTC

The iscsid got socket-activable in meantime, but this change should go in nevertheless.

Comment 2 Fedora End Of Life 2013-12-21 09:26:49 UTC

This message is a reminder that Fedora 18 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 18. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '18'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 18's end of life.

Thank you for reporting this issue and we are sorry that we may not be 
able to fix it before Fedora 18 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior to Fedora 18's end of life.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 3 Fedora End Of Life 2014-02-05 13:09:44 UTC

Fedora 18 changed to end-of-life (EOL) status on 2014-01-14. Fedora 18 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.