Bug 878500

Summary:	Review Request: rubygem-appraisal - Find out what your Ruby gems are worth
Product:	[Fedora] Fedora	Reporter:	Troy Dawson <tdawson>
Component:	Package Review	Assignee:	Miroslav Suchý <msuchy>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	msuchy, notting, package-review
Target Milestone:	---	Flags:	msuchy: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-12-08 04:24:19 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Troy Dawson 2012-11-20 14:53:57 UTC

Spec URL: http://tdawson.fedorapeople.org/rubygems/rubygem-appraisal.spec
SRPM URL: http://tdawson.fedorapeople.org/rubygems/rubygem-appraisal-0.5.1-1.fc18.src.rpm
Description: Appraisal integrates with bundler and rake to test your library against different versions of dependencies in repeatable scenarios called appraisals.
Fedora Account System Username: tdawson

RPMLINT OUTPUT:
rpmlint rubygem-appraisal.spec rubygem-appraisal-0.5.1-1.fc18.src.rpm rubygem-appraisal-0.5.1-1.fc18.noarch.rpm rubygem-appraisal-doc-0.5.1-1.fc18.noarch.rpm
rubygem-appraisal.src: W: spelling-error %description -l en_US bundler -> bundle, blunder, bundles
rubygem-appraisal.noarch: W: spelling-error %description -l en_US bundler -> bundle, blunder, bundles
3 packages and 1 specfiles checked; 0 errors, 2 warnings.

Comment 1 Miroslav Suchý 2012-11-30 08:06:39 UTC

export CONFIGURE_ARGS="--with-cflags='%{optflags}'"
This does not have sense when not compiled.

# gem install compiles any C extensions and installs into a directory
Again, this is copy'n'paste from template in guidelines, but this comment really does not have sense, since this module is not written in C.

Please remove in %install 
rm -f %{buildroot}%{gem_instdir}/.yardoc
for those of us who has yard installed.

None of these is blocker, but it would be nice if you can fix it before commiting to dist-git.

APPROVED

Comment 2 Troy Dawson 2012-11-30 14:24:55 UTC

New Package SCM Request
=======================
Package Name: rubygem-appraisal
Short Description: Find out what your Ruby gems are worth
Owners: tdawson
Branches: f18 f17
InitialCC:

Comment 3 Gwyn Ciesla 2012-11-30 14:42:20 UTC

Git done (by process-git-requests).

Comment 4 Troy Dawson 2012-11-30 15:07:13 UTC

C extensions stuff removed
yardoc removal added

Comment 5 Fedora Update System 2012-11-30 15:56:38 UTC

rubygem-appraisal-0.5.1-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/rubygem-appraisal-0.5.1-1.fc18

Comment 6 Fedora Update System 2012-11-30 20:29:15 UTC

rubygem-appraisal-0.5.1-1.fc18 has been pushed to the Fedora 18 testing repository.

Comment 7 Fedora Update System 2012-12-08 04:24:21 UTC

rubygem-appraisal-0.5.1-1.fc18 has been pushed to the Fedora 18 stable repository.