Bug 878779

Summary:	domdisplay with --include-password can't display VNC passwor
Product:	Red Hat Enterprise Linux 6	Reporter:	hongming <honzhang>
Component:	libvirt	Assignee:	Martin Kletzander <mkletzan>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.4	CC:	acathrow, dallan, dyasny, dyuan, mkletzan, mzhan, pkrempa, rwu, zpeng
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-0.10.2-11.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-02-21 07:27:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	886216

Description hongming 2012-11-21 08:41:49 UTC

Description of problem:
The domdisplay with --include-password can't display VNC password. But it works for spice .


Version-Release number of selected component (if applicable):
libvirt-0.10.2-9.el6.x86_64 

How reproducible:
100% 

Steps to Reproduce:
1. # virsh dumpxml rhel6 --security-info|grep graphics
<graphics type='vnc' port='5901' autoport='yes' listen='0.0.0.0' passwd='redhat'>
</graphics>


2.# virsh domdisplay rhel6 --include-password
vnc://localhost:1

  
Actual results:
The domdisplay with --include-password can't display VNC password.

Expected results:
Can display VNC password. 

Additional info:

Comment 3 Peter Krempa 2012-11-28 15:44:36 UTC

Fixed in upstream commit:

commit 1d4f41fdbeb13d7860dec9ad17843b494fbb41b7
Author: Martin Kletzander <mkletzan>
Date:   Wed Nov 21 16:31:51 2012 +0100

    virsh: Rewrite cmdDomDisplay
    
    Just a little rewrite of the cmdDomDisplay function to make it
    consistent and hopefully more readable.  This also fixes a problem
    with password not being displayed for vnc even with the
    "--include-password" option.

Comment 5 zhe peng 2012-12-06 06:53:16 UTC

I can reproduce this with:
libvirt-0.10.2-10.el6.x86_64

verify with:
libvirt-0.10.2-11.el6.x86_64

step:
 1:# virsh dumpxml rhel6.4 --security-info | grep graphics
    <graphics type='vnc' port='5901' autoport='yes' listen='127.0.0.1' passwd='redhat'>
    </graphics>
 2:# virsh domdisplay rhel6.4 --include-password
vnc://:redhat.0.1:1
 password display,verification passed.

Comment 6 errata-xmlrpc 2013-02-21 07:27:13 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0276.html