Bug 878940
Summary: | spout/drain examples fixes and improvements | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise MRG | Reporter: | Petr Matousek <pematous> | ||||||||
Component: | perl-qpid | Assignee: | messaging-bugs <messaging-bugs> | ||||||||
Status: | VERIFIED --- | QA Contact: | Petr Matousek <pematous> | ||||||||
Severity: | medium | Docs Contact: | |||||||||
Priority: | medium | ||||||||||
Version: | Development | CC: | jross | ||||||||
Target Milestone: | --- | Keywords: | Patch | ||||||||
Target Release: | --- | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | perl-qpid-0.18-2 | Doc Type: | Bug Fix | ||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | Type: | Bug | |||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Attachments: |
|
Description
Petr Matousek
2012-11-21 15:30:07 UTC
Created attachment 649277 [details]
patch for spout.pl
Created attachment 649278 [details]
patch for drain.pl
I think, on top of this, the usage subroutine ought to include help on the actual options available. Simply showing "[OPTIONS]" isn't very helpful. (In reply to comment #3) > I think, on top of this, the usage subroutine ought to include help on the > actual options available. Simply showing "[OPTIONS]" isn't very helpful. Agreed +1 I've written a few additions that use Pod::Usage to show help information. If you like this, I'll go ahead and commit the patch. Created attachment 652226 [details]
Adds fixes to spout.pl and drain.pl
(In reply to comment #5) > I've written a few additions that use Pod::Usage to show help information. > If you like this, I'll go ahead and commit the patch. Hi Darryl, the changes looks good to me, please go ahead and commit the patch. Thanks. Just a small detail - you provide the following options "help|h|?" to display the help using spout, drain uses only "help|h" ('?' omitted). (In reply to comment #7) > (In reply to comment #5) > > I've written a few additions that use Pod::Usage to show help information. > > If you like this, I'll go ahead and commit the patch. > > Hi Darryl, the changes looks good to me, please go ahead and commit the > patch. Thanks. > > Just a small detail - you provide the following options "help|h|?" to > display the help using spout, drain uses only "help|h" ('?' omitted). Okay, fixed that before pushing by removing ? from spout to keep it consistent. This issue has been resolved. Verified on rhel6.3 (x86_64, i386) - perl-qpid-0.18-2. -> VERIFIED (In reply to comment #11) > This issue has been resolved. > > Verified on rhel6.3 (x86_64, i386) - perl-qpid-0.18-2. > > -> VERIFIED -> Moving back to ON_QA in order to verify on 0.22 packages. Although it was not possible to verify exactly the requested changes (because a new qpid::messaging perl layer was added above the c++ swig bindings). All the reported issues are fixed in the new implementation. This issue has been fixed. Verified on rhel6.5 (x86_64, i386). packages under test: perl-qpid-0.22-11 -> VERIFIED |