Bug 878986

This is a slightly more robust version of get_terminal_size() that doesn't throw a traceback in the event of no stty.  It was modified from console.py which is apparently included in another version of python:


def getTerminalSize():
    import os
    env = os.environ
    def ioctl_GWINSZ(fd):
        try:
            import fcntl, termios, struct
            cr = struct.unpack('hh', fcntl.ioctl(fd, termios.TIOCGWINSZ,
        '1234'))
            print cr
        except:
            return
        return cr
    cr = ioctl_GWINSZ(0) or ioctl_GWINSZ(1) or ioctl_GWINSZ(2)
    if not cr:
        try:
            fd = os.open(os.ctermid(), os.O_RDONLY)
            cr = ioctl_GWINSZ(fd)
            os.close(fd)
        except:
            pass
    if not cr:
        #defaults would go here, currently 25 and 80
        cr = (env.get('LINES', 25), env.get('COLUMNS', 80))

    return int(cr[0]), int(cr[1])


For option B above, we would set the defaults to None (which I like better anyway).  The return statement here could be minimally modified to behave the same way as the existing function.

https://github.com/candlepin/subscription-manager/pull/421

commit 4ed8da58cfa992e0a01b04523c084da193d7a59e
Author: Bryan Kearney <bkearney>
Date:   Mon Nov 26 14:18:49 2012 -0500

    878986: Default to no line breaking if no stty is available


Cherry pick request has been put in.

Version...
[root@jsefler-6workstation ~]# rpm -q subscription-manager
subscription-manager-1.1.10-1.git.3.26d45eb.el6.x86_64


Not sure what was actually implemented for this bug.
Unfortunately side affects are occuring that block our automated tests...


I am getting the following traceback in rhsm.log...
2012-12-03 14:08:05,692 [ERROR]  @managercli.py:115 - exception caught in subscription-manager
2012-12-03 14:08:05,692 [ERROR]  @managercli.py:116 - setupterm: could not find terminfo database
Traceback (most recent call last):
  File "/usr/sbin/subscription-manager", line 78, in <module>
    sys.exit(abs(main() or 0))
  File "/usr/sbin/subscription-manager", line 69, in main
    return managercli.ManagerCLI().main()
  File "/usr/share/rhsm/subscription_manager/managercli.py", line 2042, in __init__
    CLI.__init__(self, command_classes=commands)
  File "/usr/share/rhsm/subscription_manager/cli.py", line 77, in __init__
    cmd = clazz()
  File "/usr/share/rhsm/subscription_manager/managercli.py", line 847, in __init__
    ent_dir, prod_dir)
  File "/usr/share/rhsm/subscription_manager/managercli.py", line 443, in __init__
    prod_dir)
  File "/usr/share/rhsm/subscription_manager/managercli.py", line 195, in __init__
    self.columns = get_terminal_width()
  File "/usr/share/rhsm/subscription_manager/utils.py", line 299, in get_terminal_width
    curses.setupterm()
error: setupterm: could not find terminfo database


Here is a one liner to reproduce the error...
> [root@jsefler-6server ~]# ssh root.redhat.com "expect -c \"spawn subscription-manager register --username=testuser1 --org=admin; expect \"*Password:\"; send foobar\r ; expect eof; catch wait reason; exit [lindex \$reason 3]\""
> root.redhat.com's password: 
> spawn subscription-manager register --username=testuser1 --org=admin
> setupterm: could not find terminfo database
> send: spawn id exp3 not open
>     while executing
> "send foobar\r "
> [root@jsefler-6server ~]# 


Moving status back to ASSIGNED

I'm going to revert 0eebba0ab85c2aa3905e60a38e6368b24f718a52, that
should fix the formatting, and get rid of the terminfo problem when ran under expect.

0eebba0ab85c2aa3905e60a38e6368b24f718a52 reverted,

in master:

commit fef10129c2e84a09cfc9ee071b3ca1049ddbe0b3
Author: Adrian Likins <alikins>
Date:   Tue Dec 4 13:19:38 2012 -0500

    Revert "878986: refactor to use curses/textwrap for format"
    
    This reverts commit 0eebba0ab85c2aa3905e60a38e6368b24f718a52.
    
    expect driven scripts dont seem to setup a term in
    a way that curses will work, so revert this.


in rhel-64:

commit d679cb276386a9de4560e6279e04b5027b4a2438
Author: Adrian Likins <alikins>
Date:   Tue Dec 4 13:19:38 2012 -0500

    Revert "878986: refactor to use curses/textwrap for format"
    
    This reverts commit 0eebba0ab85c2aa3905e60a38e6368b24f718a52.
    
    expect driven scripts dont seem to setup a term in
    a way that curses will work, so revert this.

Should land in 1.1.11

Verifying Version....
[root@jsefler-6 ~]# rpm -q subscription-manager
subscription-manager-1.1.11-1.el6.x86_64

> [root@jsefler-6 ~]# ssh root.redhat.com "expect -c \"spawn subscription-manager register --username=testuser1 --org=admin; expect \"*Password:\"; send foobar\r ; expect eof; catch wait reason; exit [lindex \$reason 3]\""
> root.redhat.com's password: 
> spawn subscription-manager register --username=testuser1 --org=admin
> Password: 
> Invalid Credentials
> [root@jsefler-6 ~]# 

^ VERIFIED: no longer encounters "setupterm: could not find terminfo database"


> [root@jsefler-6 ~]# ssh root.redhat.com "subscription-manager list --consumed"
> root.redhat.com's password: 
> No consumed subscription pools to list
> [root@jsefler-6 ~]# 

^ VERIFIED: no longer encounters "stty: standard input: Invalid argument"


Moving this bugzilla status to VERIFIED.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-0350.html