Bug 879016

Created attachment 650555 [details]
phpMemcachedAdmin-review.txt

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-17-x86_64
Command line :/usr/bin/fedora-review -b 879016

See the issues in the attachement

Blocker : Missing LICENSE

Thank you Remi for taking that review :)

I've reported the missing license upstream:
https://code.google.com/p/phpmemcacheadmin/issues/detail?id=17

I'll update with the other corrections soon.

Here is the updated version:

Spec URL: http://odysseus.x-tnd.be/fedora/phpMemcachedAdmin/phpMemcachedAdmin.spec
SRPM URL: http://odysseus.x-tnd.be/fedora/phpMemcachedAdmin/phpMemcachedAdmin-1.2.2-4.svn262.fc17.src.rpm

Here a new minor version, adding license file and fixing typo on 'information':

Spec URL: http://odysseus.x-tnd.be/fedora/phpMemcachedAdmin/phpMemcachedAdmin.spec
SRPM URL: http://odysseus.x-tnd.be/fedora/phpMemcachedAdmin/phpMemcachedAdmin-1.2.2-5.svn262.fc17.src.rpm

--- phpMemcachedAdmin.spec.prev	2012-11-23 17:41:44.000000000 +0100
+++ phpMemcachedAdmin.spec	2012-11-24 10:04:29.000000000 +0100
@@ -9,14 +9,18 @@
 Summary:     Graphic stand-alone administration for memcached to monitor and debug purpose
 Name:        phpMemcachedAdmin
 Version:     1.2.2
-Release:     3.svn%{svn}%{?dist}
+Release:     5.svn%{svn}%{?dist}
 License:     ASL 2.0
 Group:       Applications/Internet
 URL:         http://code.google.com/p/phpmemcacheadmin/
 Source0:     http://phpmemcacheadmin.googlecode.com/files/%{name}-%{version}-r%{svn}.tar.gz
 Source1:     phpMemcachedAdmin.htaccess
+#Missing license file, see:
+#https://code.google.com/p/phpmemcacheadmin/issues/detail?id=17
+Source2:     phpMemcachedAdmin.LICENSE
 Requires:    httpd, mod_php
 Requires:    php-common >= 5.2.0
+Requires:    php-date
 %if %{useselinux}
 Requires(post):   /sbin/service
 Requires(post):   /sbin/restorecon
@@ -34,15 +38,15 @@
 This program allows to see in real-time (top-like) or from the start of the
 server, stats for get, set, delete, increment, decrement, evictions, reclaimed,
 cas command, as well as server stats (network, items, server version) with
-googlecharts and server internal configuration
+googlecharts and server internal configuration.
 
 You can go further to see each server slabs, occupation, memory wasted and
 items (key & value).
 
 Another part can execute commands to any memcached server : get, set, delete,
-flush_all, as well as execute any commands (like stats) with telnet
+flush_all, as well as execute any commands (like stats) with telnet.
 
-To extract these informations, phpMemcacheAdmin uses, as you wish, direct
+To extract this information, phpMemcacheAdmin uses, as you wish, direct
 communication with server, PECL Memcache or PECL Memcached API. 
 
 
@@ -53,6 +57,7 @@
     Config/Memcache.php
 sed -i -e "s|./Config/|%{_sysconfdir}/%{name}/|" \
     Library/Configuration/Loader.php
+cp %{SOURCE2} LICENSE
 
 
 %build
@@ -104,7 +109,7 @@
 
 %files
 %defattr(-,root,root,-)
-%doc
+%doc LICENSE
 %dir %{_datadir}/%{name}
 %{_datadir}/%{name}/*
 %dir %{_sysconfdir}/%{name}
@@ -114,6 +119,14 @@
 %dir %attr(0755,apache,apache) %{_localstatedir}/lib/%{name}/Temp
 
 %changelog
+* Sat Nov 24 2012 Johan Cwiklinski <johan AT x-tnd DOT be> 1.2.2-5.svn262
+- Fix a typo
+- Add licence file
+
+* Fri Nov 23 2012 Johan Cwiklinski <johan AT x-tnd DOT be> 1.2.2-4.svn262
+- missing php-date requires
+- missing ending dots in %%description
+
 * Tue Nov 12 2012 Johan Cwiklinski <johan AT x-tnd DOT be> 1.2.2-3.svn262
 - Make config writable from web interface (with selinux also)

No more blocker.

=== APPROVED ===

Thank you for the review :)

New Package SCM Request
=======================
Package Name: phpMemcachedAdmin
Short Description: Graphic stand-alone administration for memcached to monitor and debug purpose.
Owners: trasher
Branches: f17 f18 el6
InitialCC:

Git done (by process-git-requests).

phpMemcachedAdmin-1.2.2-5.svn262.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/phpMemcachedAdmin-1.2.2-5.svn262.fc18

phpMemcachedAdmin-1.2.2-5.svn262.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/phpMemcachedAdmin-1.2.2-5.svn262.fc17

phpMemcachedAdmin-1.2.2-5.svn262.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/phpMemcachedAdmin-1.2.2-5.svn262.el6

phpMemcachedAdmin-1.2.2-5.svn262.el6 has been pushed to the Fedora EPEL 6 testing repository.

phpMemcachedAdmin-1.2.2-5.svn262.fc17 has been pushed to the Fedora 17 stable repository.

phpMemcachedAdmin-1.2.2-5.svn262.fc18 has been pushed to the Fedora 18 stable repository.

phpMemcachedAdmin-1.2.2-5.svn262.el6 has been pushed to the Fedora EPEL 6 stable repository.