Bug 879291

Summary:	left-pane tree: "expand all" should fully-expand only the selected tree-node (and not the entire tree, unless "System" is selected)
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Miki Kenneth <mkenneth>
Component:	ovirt-engine-webadmin-portal	Assignee:	Alexander Wels <awels>
Status:	CLOSED ERRATA	QA Contact:	Jiri Belka <jbelka>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.1.0	CC:	cboyle, dyasny, ecohen, iheim, Rhev-m-bugs, sgrinber, ykaul
Target Milestone:	---	Keywords:	Improvement
Target Release:	3.2.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	ux
Fixed In Version:	sf12	Doc Type:	Enhancement
Doc Text:	When in tree view, clicking 'expand all' would expand the entire tree and not just the nodes under the selected node. This was not the expected behaviour. This has been changed so that when 'expand all' is now clicked, only the nodes under the selected node are expanded, and the other unselected nodes remain untouched.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-06-10 21:22:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Miki Kenneth 2012-11-22 14:43:41 UTC

In the tree view, when you click on a specific DC and do expand, only one level is opened. It is more useful to expand all in this case or add and option to expand all.

Comment 1 Miki Kenneth 2012-11-22 15:00:35 UTC

there is an option to expand/collapse  on the whole system.

Comment 2 Einav Cohen 2012-12-19 14:29:48 UTC

I think that regular expand should still be reserved for opening only a single level.

I suggest to utilize the already-existing "expand all" button to expand only the selected node in the tree: If "System" is selected, all tree will be fully expanded. If a non-System node is selected (e.g. a node that represents a DC or a Cluster), only this node will be fully-expanded (rest of the tree will remain as is).

Thoughts?

Comment 3 Simon Grinberg 2012-12-19 15:13:43 UTC

(In reply to comment #2)
> I think that regular expand should still be reserved for opening only a
> single level.
> 
> I suggest to utilize the already-existing "expand all" button to expand only
> the selected node in the tree: If "System" is selected, all tree will be
> fully expanded. If a non-System node is selected (e.g. a node that
> represents a DC or a Cluster), only this node will be fully-expanded (rest
> of the tree will remain as is).
> 
> Thoughts?

+1 

Actually I think this is what Miki have meant when she said expand all on an object. 

It's more like, expand all descending levels from this point.

Comment 4 Einav Cohen 2012-12-19 19:24:59 UTC

thanks, changing subject accordingly.

Comment 5 Alexander Wels 2013-01-11 22:09:23 UTC

Patch to fix this issue available here:
http://gerrit.ovirt.org/10913

Comment 9 Jiri Belka 2013-04-02 08:28:14 UTC

ok, sf12.

Comment 12 errata-xmlrpc 2013-06-10 21:22:39 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2013-0888.html