Bug 879655
Summary: | ResourceContainer can enter an inconsistent state after resource upgrade during agent startup | |||
---|---|---|---|---|
Product: | [Other] RHQ Project | Reporter: | Lukas Krejci <lkrejci> | |
Component: | Agent | Assignee: | RHQ Project Maintainer <rhq-maint> | |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> | |
Severity: | high | Docs Contact: | ||
Priority: | unspecified | |||
Version: | 4.5 | CC: | hrupp, jshaughn | |
Target Milestone: | --- | |||
Target Release: | RHQ 4.6 | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 880562 (view as bug list) | Environment: | ||
Last Closed: | 2013-09-03 14:43:32 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 880562 |
Description
Lukas Krejci
2012-11-23 15:16:14 UTC
I'm quite confident the below fixes the issue - i.e. a failure in stop() can no longer put the resource container in an invalid state. Jay, can you see anything wrong with it or does it remind you of some other areas that would need similar treatment? master http://git.fedorahosted.org/cgit/rhq/rhq.git/diff/?id=844f016ee8b2608496d063c94f38461e997bcabe Author: Lukas Krejci <lkrejci> Date: Fri Nov 23 17:18:35 2012 +0100 [BZ 879655] - Properly deactivate the resource instead of just calling the component's stop() method when forcing reactivation of a started component. This will ensure the PC can't enter an inconsistent state in the case the stop() method fails. This change looks correct to me. There were some relatively recent changes in this code, made by myself and Ian I think, to better handle a "starting" state in the component lifecycle. This looks like an issue resulting from, or more exposed by, those changes. Moving to ON_QA. Bulk closing of issues in old RHQ releases that are in production for a while now. Please open a new issue when running into an issue. |