Created attachment 651999[details]
vdsm.log + engine.log
Description of problem:
VLAN tagged 4095 can be defined in webadmin but it cannot be assigned to host. Following error appears in vdsm.log:
ConfigNetworkError: (26, "vlan id out of range: '4095', must be 0..4094")
it should be possible to assign VLAN with tag 4095, despite the fact that this tag is used for special purposes by some vendors
Version-Release number of selected component (if applicable):
Red Hat Enterprise Virtualization Manager Version: 3.1.0-31.el6ev
vdsm-4.9.6-44.0.el6_3.x86_64
libvirt-0.9.10-21.el6_3.6.x86_64
How reproducible:
100%
Steps to Reproduce:
1. Create VLAN tagged 4095
2. Try to attach the VLAN to host via Setup Networks dialog
Actual results:
VLAN is not attached
Expected results:
VLAN attached
Additional info:
engine.log
2012-11-26 15:47:01,528 ERROR [org.ovirt.engine.core.bll.SetupNetworksCommand] (ajp-/127.0.0.1:8702-3) [4da9246f] Command org.ovirt.engine.core.bll.SetupNetworksCommand throw Vdc Bll exception. With error message VdcBLLException: org.ovirt.engine.core.vdsbroker.vdsbroker.VDSErrorException: VDSGenericException: VDSErrorException: Failed to SetupNetworksVDS, error = vlan id out of range: '4095', must be 0..4094
vdsm.log
ainProcess|Thread-255956::ERROR::2012-11-26 14:47:01,435::supervdsmServer::68::SuperVdsm.ServerCallback::(wrapper) Error in setupNetworks
Traceback (most recent call last):
File "/usr/share/vdsm/supervdsmServer.py", line 66, in wrapper
File "/usr/share/vdsm/supervdsmServer.py", line 118, in setupNetworks
File "/usr/share/vdsm/configNetwork.py", line 1355, in setupNetworks
File "/usr/share/vdsm/configNetwork.py", line 886, in addNetwork
File "/usr/share/vdsm/configNetwork.py", line 810, in _addNetworkValidation
File "/usr/share/vdsm/configNetwork.py", line 743, in validateVlanId
ConfigNetworkError: (26, "vlan id out of range: '4095', must be 0..4094")
Thread-255956::ERROR::2012-11-26 14:47:01,444::API::1138::vds::(setupNetworks) vlan id out of range: '4095', must be 0..4094
Traceback (most recent call last):
File "/usr/share/vdsm/API.py", line 1136, in setupNetworks
File "/usr/share/vdsm/supervdsm.py", line 69, in __call__
File "/usr/share/vdsm/supervdsm.py", line 60, in <lambda>
File "<string>", line 2, in setupNetworks
File "/usr/lib64/python2.6/multiprocessing/managers.py", line 740, in _callmethod
ConfigNetworkError: (26, "vlan id out of range: '4095', must be 0..4094")
Thread-255956::DEBUG::2012-11-26 14:47:01,453::BindingXMLRPC::900::vds::(wrapper) return setupNetworks with {'status': {'message': "vlan id out of range: '4095', must be 0..4094", 'code': 26}}
The 4094 limitation was intentional, as 4095 is not allowed by Linux
ioctl(3, SIOCSIFVLAN, 0x7fff1fe7d620) = -1 ERANGE (Numerical result out of range)
this bug should be either pushed down to kernel (to accept this reserved value), or up to Engine (to block people from using it). I vote for the latter.
Created attachment 651999 [details] vdsm.log + engine.log Description of problem: VLAN tagged 4095 can be defined in webadmin but it cannot be assigned to host. Following error appears in vdsm.log: ConfigNetworkError: (26, "vlan id out of range: '4095', must be 0..4094") it should be possible to assign VLAN with tag 4095, despite the fact that this tag is used for special purposes by some vendors Version-Release number of selected component (if applicable): Red Hat Enterprise Virtualization Manager Version: 3.1.0-31.el6ev vdsm-4.9.6-44.0.el6_3.x86_64 libvirt-0.9.10-21.el6_3.6.x86_64 How reproducible: 100% Steps to Reproduce: 1. Create VLAN tagged 4095 2. Try to attach the VLAN to host via Setup Networks dialog Actual results: VLAN is not attached Expected results: VLAN attached Additional info: engine.log 2012-11-26 15:47:01,528 ERROR [org.ovirt.engine.core.bll.SetupNetworksCommand] (ajp-/127.0.0.1:8702-3) [4da9246f] Command org.ovirt.engine.core.bll.SetupNetworksCommand throw Vdc Bll exception. With error message VdcBLLException: org.ovirt.engine.core.vdsbroker.vdsbroker.VDSErrorException: VDSGenericException: VDSErrorException: Failed to SetupNetworksVDS, error = vlan id out of range: '4095', must be 0..4094 vdsm.log ainProcess|Thread-255956::ERROR::2012-11-26 14:47:01,435::supervdsmServer::68::SuperVdsm.ServerCallback::(wrapper) Error in setupNetworks Traceback (most recent call last): File "/usr/share/vdsm/supervdsmServer.py", line 66, in wrapper File "/usr/share/vdsm/supervdsmServer.py", line 118, in setupNetworks File "/usr/share/vdsm/configNetwork.py", line 1355, in setupNetworks File "/usr/share/vdsm/configNetwork.py", line 886, in addNetwork File "/usr/share/vdsm/configNetwork.py", line 810, in _addNetworkValidation File "/usr/share/vdsm/configNetwork.py", line 743, in validateVlanId ConfigNetworkError: (26, "vlan id out of range: '4095', must be 0..4094") Thread-255956::ERROR::2012-11-26 14:47:01,444::API::1138::vds::(setupNetworks) vlan id out of range: '4095', must be 0..4094 Traceback (most recent call last): File "/usr/share/vdsm/API.py", line 1136, in setupNetworks File "/usr/share/vdsm/supervdsm.py", line 69, in __call__ File "/usr/share/vdsm/supervdsm.py", line 60, in <lambda> File "<string>", line 2, in setupNetworks File "/usr/lib64/python2.6/multiprocessing/managers.py", line 740, in _callmethod ConfigNetworkError: (26, "vlan id out of range: '4095', must be 0..4094") Thread-255956::DEBUG::2012-11-26 14:47:01,453::BindingXMLRPC::900::vds::(wrapper) return setupNetworks with {'status': {'message': "vlan id out of range: '4095', must be 0..4094", 'code': 26}}